[#42776] - [5.1] Rewrite treeselect in vanilla JS
- Fixed in Code Base
- 26 Feb 2024
- Medium
- Build: 5.1-dev
- # 42776
- Diff
- C-Lodder:treeselectmenu-js
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR removes the jQuery dependency for the treeselect Javascript.
Also uses a <div> for the dropdown heading, as opposed to a <h1>.
Testing Instructions
- Go to edit any module in the Module Manager.
- Navigate to the "Menu Assignment" tab
- Select "Only on the pages selected"
- Play around with all the treeselect options (expanding, collapsing, checking, unchecking, etc)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules Repository NPM Change JavaScript |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
| Labels |
Added:
Feature
|
||
I have tested this item ✅ successfully on 4f775be
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42776.
| Status | Pending | ⇒ | Ready to Commit |
r2c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42776.
| Labels |
Added:
RTC
|
||
Thank you for your work @C-Lodder I tested this and as soon as an individual menu item has been manually selected/deselected, the dropdown next to it for the entire menu for "selecting/deselecting" all menu items no longer has any effect on the previously manually changed entry.
Only again after the complete page refresh.
However, this error already exists in the old version.
Could you please take a look here?
| Status | Ready to Commit | ⇒ | Pending |
@LadySolveig Can do, but the toolbar in the edit view is missing. I this a known bug with the recent upmerge?
but the toolbar in the edit view is missing
Clear the cache for autoload_psr4.php
| Labels |
Added:
Updates Requested
Removed: RTC |
||
@LadySolveig Good catch. Fixed now
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-26 10:06:24 |
| Closed_By | ⇒ | LadySolveig |
Thank you for your work @C-Lodder and also to the testers and support @fgsw @Fedik @dgrammatiko
I have tested this item ✅ successfully on 29ae5d3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42776.