Feature NPM Resource Changed PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
7 Feb 2024

Summary of Changes

This PR addresses two items:

  1. Two of the toolbar buttons ("Save Target" and "Copy Reference to Target") were missing an ID and therefore were not hidden as the JS couldn't find them.
  2. Remove the jQuery dependency for the com_associations sidebyside JS

Testing Instructions

  1. Ensure you have a multilingual site setup.
  2. Play around with com_associations and make sure it's all working as expected.
avatar C-Lodder C-Lodder - open - 7 Feb 2024
avatar C-Lodder C-Lodder - change - 7 Feb 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2024
Category Administration com_associations Repository NPM Change JavaScript
avatar C-Lodder C-Lodder - change - 8 Feb 2024
Labels Added: NPM Resource Changed PR-5.1-dev
avatar fgsw
fgsw - comment - 8 Feb 2024

@C-Lodder please inform when the PR is ready for test.

avatar C-Lodder
C-Lodder - comment - 8 Feb 2024

@fgsw It's ready now

avatar fgsw fgsw - test_item - 8 Feb 2024 - Tested successfully
avatar fgsw
fgsw - comment - 8 Feb 2024

I have tested this item ✅ successfully on be13537


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42771.

avatar Fedik
Fedik - comment - 8 Feb 2024

@C-Lodder I see you are brave man.
The whole thing is asking for a good refactoring, but moving away from jquery, at least something.
Thanks!

And please keep old copyright date, in the end it the same sidebyside.js

avatar C-Lodder C-Lodder - change - 8 Feb 2024
Labels Added: Feature
avatar LadySolveig LadySolveig - change - 24 Feb 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-24 19:31:01
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 24 Feb 2024
avatar LadySolveig LadySolveig - merge - 24 Feb 2024
avatar LadySolveig
LadySolveig - comment - 24 Feb 2024

Thank you @C-Lodder and also for testing and review @fgsw @Fedik @laoneo @dgrammatiko

Add a Comment

Login with GitHub to post a comment