[#42764] - Revert "[5.0] Switching Input object from CMS to framework class"
- Fixed in Code Base
- 6 Feb 2024
- Medium
- Build: 5.1-dev
- # 42764
- Diff
- joomla:revert-40415-5.0-input
- Pending continuous-integration/drone/push Build is running Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Reverts #40415 b/c
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users com_workflow Front End com_config com_contact com_content com_contenthistory com_fields com_modules Installation Libraries Plugins |
Revert only because of the complete replacement of class Joomla\Input\Input <-> Joomla\CMS\Input\Input - not the doc block changes.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-06 08:12:46 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
PR-5.1-dev
|
||
Thanks
Revert only because of the complete replacement of class Joomla\Input\Input <-> Joomla\CMS\Input\Input - not the doc block changes.
I understand but as Joomla\CMS\Input\Input extends from Joomla\Input\Input there isn't a b/c break. the b/c breaks are only where we create the class (because the internals aren't set by reference), widening the type hints shouldn't be a b/c break and in some cases may allow people to do easier interop going into the change default happening in J6
What is this fixing? The majority of these things are doc blocks changes (and are probably required in advance of us swapping things over in J6 or similar). The two places I can see potential real impacts are BaseApplication and WebApplication where we change the default instance over. Targeted fixes might be better there depending on exactly what b/c things have been reported.