[#42715] - [5.1] Replace deprecated KeyboardEvent code
- Fixed in Code Base
- 2 Feb 2024
- Medium
- Build: 5.1-dev
- # 42715
- Diff
- C-Lodder:keypress
User tests: Successful: Unsuccessful:
Summary of Changes
Both the keypress event and keyCode property are deprecated in Javascript. This PR replaces them accordingly.
Testing Instructions
Calendar:
Open a calendar and ensure:
- Shift + Space appends the date to the input.
- ESC closes the calendar.
- Tab closes the calendar.
- The arrow keys (↑, ↓, →, ←) navigate through the calendar accordingly.
- Repeat step 4 in RTL mode.
Web Install:
- Go to
administrator/index.php?option=com_installer&view=install, then navigate to the "Install from Web" tab. - Enter a phrase in the "Search" field.
- Press Enter.
- The search should be initiated.
@dgrammatiko I removed the following conditional statement:
if (ev.target === this.inputField && !(K>48 || K<57 || K===186 || K===189 || K===190 || K===32)) {
return stopCalEvent(ev);
}
because I could not meet the condition, and using K > 48 || K < 57 makes no sense. It's possible that this was a mistake but the code doesn't contain any comments, sol....
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
It's possible that this was a mistake but the code doesn't contain any comments
the conditional is basically a way to ignore keys other than the ones actually used by the calendar but not sure if there’s a need for it. This is code from the early 2000’s so who knows anymore…
In RTL, the left key moves to the right and right key moves to the left. Not sure if this is the correct behavior as this is not the case without this PR.
| Labels |
Added:
Feature
|
||
I have tested this item ✅ successfully on 0625506
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42715.
I have tested this item ✅ successfully on 0625506
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42715.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42715.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-02 22:50:24 |
| Closed_By | ⇒ | LadySolveig |
Thank you @C-Lodder and also for testing, support and review @dgrammatiko @Fedik @Quy @viocassel
Please use event.code instead of event.key, because the
keyis altered by keyboard locale and layout. Andcodealways represents a physical key on the keyboard.