RTC bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Jan 2024

Summary of Changes

With #36748

"This PR checks if a translation for the language key exists and if there is none (and debug is not enabled) it will instead display the taxonomy title instead."

It is confusing that this doesnt work if debug is enabled. There is nothing else in Joomla where this is the case and I just wasted a lot of time trying to see why the string wasnt displayed.

I believe that the intention of the code was to display the language key when "debug language" was enabled not when "debug" was enabled

If you want to create your own value for the key as an override you would expect the key to be displayed in debug language mode (which it is not) and you would not expect the key to be displayed in debug mode

Testing Instructions

Perform a search on the front with Debug enabled and a new search with debug language enabled

Actual result BEFORE applying this Pull Request

Debug

image

Debug Language

image

Expected result AFTER applying this Pull Request

Debug

image

Debug Language

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

1fc9447 21 Jan 2024 avatar brianteeman [4.4]
avatar brianteeman brianteeman - open - 21 Jan 2024
avatar brianteeman brianteeman - change - 21 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2024
Category Administration com_finder
avatar brianteeman brianteeman - change - 21 Jan 2024
Labels Added: bug PR-4.4-dev
avatar Quy Quy - test_item - 5 Feb 2024 - Tested successfully
avatar Quy
Quy - comment - 5 Feb 2024

I have tested this item ✅ successfully on f0ee89d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42687.

avatar fgsw fgsw - test_item - 6 Feb 2024 - Tested successfully
avatar fgsw
fgsw - comment - 6 Feb 2024

I have tested this item ✅ successfully on f0ee89d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42687.

avatar Quy Quy - change - 6 Feb 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42687.

avatar Quy Quy - change - 6 Feb 2024
Labels Added: RTC
avatar MacJoom MacJoom - change - 6 Feb 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-06 18:14:05
Closed_By MacJoom
avatar MacJoom MacJoom - close - 6 Feb 2024
avatar MacJoom MacJoom - merge - 6 Feb 2024
avatar MacJoom
MacJoom - comment - 6 Feb 2024

Thank you!

avatar brianteeman
brianteeman - comment - 6 Feb 2024

thanks

Add a Comment

Login with GitHub to post a comment