[#42685] - [5.x] Indexer taxonomy language strings
- Closed
- 21 Jan 2024
- Medium
- Build: 5.0-dev
- # 42685
- Diff
- brianteeman:debug_lang
User tests: Successful: Unsuccessful:
Summary of Changes
With #36748
"This PR checks if a translation for the language key exists and if there is none (and debug is not enabled) it will instead display the taxonomy title instead."
It is confusing that this doesnt work if debug is enabled. There is nothing else in Joomla where this is the case and I just wasted a lot of time trying to see why the string wasnt displayed.
I believe that the intention of the code was to display the language key when "debug language" was enabled not when "debug" was enabled
If you want to create your own value for the key as an override you would expect the key to be displayed in debug language mode (which it is not) and you would not expect the key to be displayed in debug mode
Testing Instructions
Perform a search on the front with Debug enabled and a new search with debug language enabled
Actual result BEFORE applying this Pull Request
Debug
Debug Language
Expected result AFTER applying this Pull Request
Debug
Debug Language
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
PR-5.0-dev
|
||
| Category | Administration com_finder | ⇒ | Repository Administration com_installer Front End com_users Libraries Plugins JavaScript Unit Tests |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-21 12:34:12 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
Unit/System Tests
|
||
@brianteeman I think it would help to change the base branch on GitHub by using the "edit" button right beside the title.
yeah - didnt work - creating a new pr instead
yeah - didnt work - creating a new pr instead
@brianteeman Ok, thanks.
Shouldn't that be fixed in 4.4-dev, as it is a bug fix and the bug also applies there?