[#42652] - [5.0] Update error.php
- Fixed in Code Base
- 23 Jan 2024
- Medium
- Build: 5.0-dev
- # 42652
- Diff
- Razzo1987:5.0-dev-include-message
User tests: Successful: Unsuccessful:
add <jdoc:include type="message" /> when you have module on error page
Summary of Changes
Added <jdoc:include type="message" /> in /templates/cassiopeia/error.php file in template "cassiopeia".
Testing Instructions
- Install Blog Sample Data
- Change the access of category Blog from Public to Registered
- Create a Site Module of type Login (or clone Login Form) and publish in Error 403 position
- Go in Site side and open the Blog item menu
You see:
- Login. You see the original Blog category
- Logout
Actual result BEFORE applying this Pull Request
You have not message from logout
If you login again:
But you is not logged out, but logged in...
Expected result AFTER applying this Pull Request
You have the logout meggase
If you login again:
You see the original Blog category without eny message
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Title |
|
||||||
Thanks @richard67, My mistake, I'll fix it!
I have tested this item ✅ successfully on 0062b15
Now works!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42652.
I have tested this item ✅ successfully on 0062b15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42652.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42652.
| Labels |
Added:
RTC
|
||
@walturbo @viocassel Could you test this PR again? It has received some change. It should still work, but if we get a retest we can be sure. Thanks in advance, and thanks for previous test.
I have tested this item ✅ successfully on 64f1e25
It's ok!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42652.
I have tested this item ✅ successfully on 64f1e25
?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42652.
Thanks for testing. So RTC status is fine again.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-23 00:31:52 |
| Closed_By | ⇒ | bembelimen |
Thx
@Razzo1987 Why for 5.0-dev? As a Release Manager you should know that new features go into 5.1-dev, and bug fixes go into 4.4-dev. So into 5.0-dev go only bug fixes which are specific to Joomla 5 where the bug doesn’t exist in 4.4-dev.