[#42651] - [5.1] Template Long Description
- Fixed in Code Base
- 3 Feb 2024
- Medium
- Build: 5.1-dev
- # 42651
- Diff
- brianteeman:satnight
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue identified with #42649 .
Summary of Changes
Complete the code that truncates long descriptions.
As seen in
administrator/components/com_modules/tmpl/module/edit.php
administrator/components/com_plugins/tmpl/plugin/edit.php
administrator/components/com_scheduler/tmpl/task/edit.php
But only partially seen in
administrator/components/com_templates/tmpl/style/edit.php
each element that used "JGLOBAL_SHOW_FULL_DESCRIPTION", have a parent element with onclick attribute...
Testing Instructions
Update the descrption of the cassiopeia template in language\en-GB\tpl_cassiopeia.ini so that it is over 500 characters long.
Actual result BEFORE applying this Pull Request
The entire description is displayed
Expected result AFTER applying this Pull Request
The description is truncated and a new tab is present with the full description
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org: <link
-
No documentation changes for manual.joomla.org needed
Comment
Alternatively the partial support for this truncation functionality can be removed from com_templates
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
| Labels |
Added:
PR-5.1-dev
|
||
I've restored the previous human test result in the issue tracker as the 2 commits after the test were only a code style change and a clean branch update.
I have tested this item ✅ successfully on 585dfd6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42651.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42651.
| Labels |
Added:
Feature
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-03 07:47:53 |
| Closed_By | ⇒ | LadySolveig |
Thank you @brianteeman and also vor testing @toivo and @Quy
thanks
I have tested this item ✅ successfully on 6501649
Tested successfully in Joomla 5.1.0-alpha3-dev of 15 January.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42651.