Feeling Lucky
RTC
PR-4.4-dev
[#42599] - [4.4] check for valid referrer
- Fixed in Code Base
- 10 Jan 2024
- Medium
- Build: 4.4-dev
- # 42599
- Diff
- heelc29:4.4/mvc/base-controller/referrer
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
check if $_SERVER['HTTP_REFERER'] is valid before call Uri::isInternal()
Testing Instructions
- login as super user in backend
- visit
https://example.tl/administrator/index.php?option=com_admin&view=sysinfo&format=text(note: link is without token!) - check php warnings (PHP >= 8.1 required)
Actual result BEFORE applying this Pull Request
PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in libraries/src/Uri/Uri.php on line 243
Expected result AFTER applying this Pull Request
No deprecation warning
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
viocassel
- comment
- 8 Jan 2024
I have tested this item ✅ successfully on 432c681
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42599.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 8 Jan 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42599.
| Labels |
Added:
RTC
PR-4.4-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-10 11:48:34 |
| Closed_By | ⇒ | MacJoom |
I have tested this item ✅ successfully on 432c681
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42599.