Feature RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
3 Jan 2024

Summary of Changes

On the CLI, we can check for updates of the core and we can run the update as well, but we actually don't know what we are updating to, what update channel we are on and what the update process is actually doing right now. This PR tries to fix some of the issues by allowing to manage the update channels.

By calling php cli/joomla.php core:update:channel, you get the update channel the site is currently on. By adding the parameter default, next, testing or custom, you can set the update channel to that respective one. For custom you need to also add the --url=<url> parameter for the custom URL.

Testing Instructions

  1. Run php cli/joomla.php core:update:channel to display the currently configured update channel.
  2. Run php cli/joomla.php core:update:channel next to set it to the "next" update channel. Check that the params column in #__extensions for the com_joomlaupdate row contains the updated updatesource value and that location column for Joomla! Core in #__update_sites contains https://update.joomla.org/core/sts/list_sts.xml as URL.
  3. Run it in addition with other combinations of options and see the change reflected in the core tables.
  4. Run php cli/joomla.php core:check-updates to check for updates from the new update source.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 3 Jan 2024
avatar Hackwar Hackwar - change - 3 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2024
Category Libraries
avatar Hackwar Hackwar - change - 3 Jan 2024
Labels Added: PR-5.1-dev
avatar alikon alikon - test_item - 4 Jan 2024 - Tested successfully
avatar alikon
alikon - comment - 4 Jan 2024

I have tested this item ✅ successfully on b4ce80a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42597.

avatar dautrich
dautrich - comment - 9 Jan 2024

I tested following the Testing Instructions. As part of the test, I set the update channel to next, testing, and custom. For custom I added the parameter --url="https://example.org/update. Thereafter, I set the update channel back to testing, but the Custom URL was not removed from the database.
I'm not sure whether this may lead to adverse effects. Clean solution would be to remove any Custom URL from the database if the update channel is set to anything but custom.

avatar brianteeman
brianteeman - comment - 9 Jan 2024

Thereafter, I set the update channel back to testing, but the Custom URL was not removed from the database.

Is it removed when you do the same in the web interface?

avatar dautrich
dautrich - comment - 9 Jan 2024

@brianteeman
No, it is not. I've set the update channel back to Default via the web interface, but the URL remains in the extensions table as well.
IMHO we would need another PR to have the URL removed.

avatar dautrich dautrich - test_item - 9 Jan 2024 - Tested successfully
avatar dautrich
dautrich - comment - 9 Jan 2024

I have tested this item ✅ successfully on b4ce80a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42597.

avatar brianteeman
brianteeman - comment - 9 Jan 2024

@brianteeman No, it is not. I've set the update channel back to Default via the web interface, but the URL remains in the extensions table as well. IMHO we would need another PR to have the URL removed.

thought so. some would consider it a good feature to have

avatar alikon alikon - change - 9 Jan 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 9 Jan 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42597.

avatar Razzo1987 Razzo1987 - change - 18 Jan 2024
Labels Added: Feature RTC
avatar Razzo1987 Razzo1987 - change - 18 Jan 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-01-18 22:56:24
Closed_By Razzo1987
avatar Razzo1987 Razzo1987 - close - 18 Jan 2024
avatar Razzo1987 Razzo1987 - merge - 18 Jan 2024
avatar Razzo1987
Razzo1987 - comment - 18 Jan 2024

Thanks!

Add a Comment

Login with GitHub to post a comment