PBF bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
3 Jan 2024

Summary of Changes

On my local system the token API authentication is not working, since the authorization header is renamed to REDIRECT_HTTP_AUTHORIZATION instead of just HTTP_AUTHORIZATION. Since our API is pretty similar to symfony, I looked at what symfony is doing and Symfony is doing the same like I'm doing here: https://github.com/symfony/symfony/blob/7.0/src/Symfony/Component/HttpFoundation/ServerBag.php#L58
Their original issue is here: symfony/symfony#1813

@SniperSister can you review this/give this a thumbs up?

Testing Instructions

I don't know how Apache needs to be actually configured to trigger this, but I hope this can be accepted by code review?

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 3 Jan 2024
avatar Hackwar Hackwar - change - 3 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2024
Category Front End Plugins
avatar SniperSister
SniperSister - comment - 3 Jan 2024

Fine for me :)

avatar richard67
richard67 - comment - 3 Jan 2024

@Hackwar Why for 5.0-dev? Either it's a bug fix, then it should go into 4.4-dev, or it's a new feature, then it should go into 5.1-dev. 5.0-dev only makes sense for bug fixes of bugs which affect only 5.x but not 4.4.y.

avatar Hackwar Hackwar - change - 5 Feb 2024
Labels Added: PR-5.0-dev
avatar Hackwar
Hackwar - comment - 5 Feb 2024

I changed it to 4.4-dev

avatar Hackwar Hackwar - change - 21 Feb 2024
Title
[5.0] Fixing API authentication issue with Apache with PHP as cgi/fastCGI
[4.4] Fixing API authentication issue with Apache with PHP as cgi/fastCGI
avatar Hackwar Hackwar - edited - 21 Feb 2024
avatar MacJoom MacJoom - change - 17 May 2024
Labels Added: PBF bug PR-4.4-dev
Removed: PR-5.0-dev
avatar MacJoom MacJoom - change - 17 May 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-05-17 16:45:21
Closed_By MacJoom
avatar MacJoom MacJoom - close - 17 May 2024
avatar MacJoom MacJoom - merge - 17 May 2024
avatar MacJoom
MacJoom - comment - 17 May 2024

Thank you!

Add a Comment

Login with GitHub to post a comment