RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
1 Jan 2024

Summary of Changes

On Facebook a user had an issue with invalid lft and rgt values in the tags table. When I told him to click "rebuild", it turns out that the tags component doesn't have that button. Upon adding it back in, it turns out that exactly only this button is missing, but the task in the controller and all other necessary code (even including the language strings) is already there. That is why I'm putting this PR against 5.0-dev as a bugfix and not a new feature against 5.1-dev. The code is there, the only thing missing right now is the button in the toolbar.

CC @brianteeman just to let you know that this issue would be fixed with this PR.

Testing Instructions

  1. Go to backend of tags component, see the missing rebuild button.
  2. Apply PR, see the button appear.
  3. Click rebuild button and see that it reports a successfull rebuild of the data.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
5.00

avatar Hackwar Hackwar - open - 1 Jan 2024
avatar Hackwar Hackwar - change - 1 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jan 2024
Category com_tags Administration
avatar toivo toivo - test_item - 2 Jan 2024 - Tested successfully
avatar toivo
toivo - comment - 2 Jan 2024

I have tested this item ✅ successfully on 1c7f4b5

Tested successfully in Joomla 5.0.2-rc2-dev of 2 January in Wampserver using PHP 8.2.13.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42586.

avatar viocassel viocassel - test_item - 2 Jan 2024 - Tested successfully
avatar viocassel
viocassel - comment - 2 Jan 2024

I have tested this item ✅ successfully on 1c7f4b5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42586.

avatar Quy Quy - change - 2 Jan 2024
Status Pending Ready to Commit
Labels Added: PR-5.0-dev
avatar Quy
Quy - comment - 2 Jan 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42586.

avatar bembelimen bembelimen - change - 2 Jan 2024
Labels Added: RTC bug
avatar bembelimen
bembelimen - comment - 2 Jan 2024

New feature => 5.1

avatar Razzo1987 Razzo1987 - change - 5 Jan 2024
Labels Added: PR-5.1-dev
Removed: bug PR-5.0-dev
avatar CCMLanger
CCMLanger - comment - 8 Jan 2024

tested succsessvully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42586.

avatar CCMLanger CCMLanger - test_item - 8 Jan 2024 - Tested successfully
avatar CCMLanger
CCMLanger - comment - 8 Jan 2024

I have tested this item ✅ successfully on 3d4f0d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42586.

avatar LadySolveig LadySolveig - change - 10 Jan 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-01-10 18:10:23
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 10 Jan 2024
avatar LadySolveig LadySolveig - merge - 10 Jan 2024
avatar LadySolveig
LadySolveig - comment - 10 Jan 2024

Thank you for the quick fix @Hackwar and for the tests @toivo @viocassel @CCMLanger

Add a Comment

Login with GitHub to post a comment