Feeling Lucky
PR-5.0-dev
[#42585] - Fix phpdoc in FeatureEvent
- Closed
- 2 Jan 2024
- Medium
- Build: 5.0-dev
- # 42585
- Diff
- Denitz:patch-15
User tests: Successful: Unsuccessful:
Summary of Changes
Invalid phpdoc
Testing Instructions
Feature/unfeature article.
Actual result BEFORE applying this Pull Request
Invalid phpdoc
Expected result AFTER applying this Pull Request
Valid phpdoc
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Title |
|
||||||
| Labels |
Added:
PR-5.0-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-02 07:50:05 |
| Closed_By | ⇒ | Denitz |
Denitz
- comment
- 2 Jan 2024
@richard67 Yes, you are right, 4.4-dev is the right place for this:
#42587
@Denitz As far as I can see, the same issue already exists in the 4.,4-dev branch. So if we consider your fix to be a bug fix, it should be made for 4.4-dev and later will be merged up into 5.0-dev. And if we consider it a new feature (which would be not appropriate, I think) it would go into 5.1-dev. I've asked maintainers for their opinion and will let you know the result, but I think it would also be ok if you just rebase to or redo it for 4.4-dev.