Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42562] - [4][com_actionlogs] missed load plugin languages

RTC Unit/System Tests bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
22 Dec 2023

Pull Request for Issue #28540.

Summary of Changes

load language from:

  • plg_system_privacyconsent
  • plg_user_terms

Testing Instructions

enable user term plugin - register a new user and consent to the terms and conditions during registration.
enable sytem privacy plugin - and consent to the privacy policy.

on dashboard Latest Actions module check that string are translated correctly

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 22 Dec 2023
avatar alikon alikon - change - 22 Dec 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Dec 2023
Category ⇒ Administration
avatar Kostelano Kostelano - test_item - 22 Dec 2023 - Tested successfully
avatar Kostelano
Kostelano - comment - 22 Dec 2023

I have tested this item ✅ successfully on d1456e9

This works, thanks. A very old mistake.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42562.

avatar viocassel viocassel - test_item - 23 Dec 2023 - Tested successfully
avatar viocassel
viocassel - comment - 23 Dec 2023

I have tested this item ✅ successfully on d1456e9

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42562.

avatar richard67 richard67 - change - 23 Dec 2023
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 23 Dec 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42562.

avatar MacJoom MacJoom - change - 23 Dec 2023
Labels Added: RTC bug PR-4.4-dev
avatar MacJoom
MacJoom - comment - 23 Dec 2023

@alikon Thanks for the PR - can you think of a reason why drone is failing at administrator/components/com_privacy/Consent.cy.js for psql?

avatar joomla-cms-bot joomla-cms-bot - change - 24 Dec 2023
Category Administration ⇒ Administration JavaScript Unit Tests
avatar alikon
alikon - comment - 24 Dec 2023

somekind of "duplicate key value violates unique constraint cpostgres_users_pkey"

avatar richard67
richard67 - comment - 25 Dec 2023

somekind of "duplicate key value violates unique constraint cpostgres_users_pkey"

Reason could be that some users are inserted into the database with given ID in the insert statement, but on postgresql the sequence value for the ID column is not updated after that.

avatar MacJoom MacJoom - change - 26 Dec 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-12-26 16:23:43
Closed_By ⇒ MacJoom
Labels Added: Unit/System Tests
avatar MacJoom MacJoom - close - 26 Dec 2023
avatar MacJoom MacJoom - merge - 26 Dec 2023
avatar MacJoom
MacJoom - comment - 26 Dec 2023

Thank you!

Add a Comment

Login with GitHub to post a comment