[#42509] - [5.2] replace scss variables by css variables
- Fixed in Code Base
- 30 Apr 2024
- Medium
- Build: 5.1-dev
- # 42509
- Diff
- hans2103:feature/41105=hard-coded-colors-instead-of-css-variables
User tests: Successful: Unsuccessful:
Pull Request for Issue #41105 .
Summary of Changes
This PR will replace the SCSS variables used to adjust the styling of btn-secondary by css variables.
With this change we are more in line with the rest of the css using css variables
Testing Instructions
Before and after the test the look and feel of an element with className btn-secondary should be the same
- Have a Joomla website up and running
- Apply this PR
- Rebuild the assets using
npm run watch(or similar) - Refresh the page
- Inspect the css inside Dev Toolbar
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Title |
|
||||||
quest for your own issue then please close th
my bad... thank you
The Download is not available (Expected — Waiting for status to be reported).
Not expected - it should not take 2 days ;)
Prebuilt Download Packages are available here https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42509/downloads/72262
| Labels |
Added:
Feature
NPM Resource Changed
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 9d24a00
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42509.
I have tested this item ✅ successfully on 9d24a00
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42509.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42509.
| Labels |
Added:
RTC
|
||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Labels |
Added:
PR-5.2-dev
|
||
| Labels |
Removed:
PR-5.1-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-30 13:05:58 |
| Closed_By | ⇒ | pe7er |
@hans2103 When you make a pull request for your own issue then please close the issue.