[#42508] - [5.1] Replace hard coded img element by JLayout joomla.html.image and DRY
- Fixed in Code Base
- 28 Feb 2024
- Medium
- Build: 5.0-dev
- # 42508
- Diff
- hans2103:feature/5.1-dev/replace-img-by-jlayout
User tests: Successful: Unsuccessful:
Pull Request for no Issue
This PR replaces #40618
After solving the merge conflicts there are just too many changed files.
Summary of Changes
This PR will change the hard coded <img src=""... inside the default view of mod_banners by a call to JLayout joomla.html.image and keeps it DRY.
Testing Instructions
- Joomla 5 with testing sample data. (adjust mod_banners config and unset the chosen client, otherwise you don't see images... #40616)
- Go to frontend index.php/banners
Actual result BEFORE applying this Pull Request
You will see a banner image on the page.
Expected result AFTER applying this Pull Request
You will see a banner image on the page. The same as BEFORE. The HTML output is also the same as BEFORE.
The only difference is that it is rendered by JLayout which allows users to create an override.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin com_banners com_categories com_contact com_fields |
| Labels |
Added:
Unit/System Tests
PR-5.1-dev
|
||
| Category | Unit Tests Repository Administration com_admin com_banners com_categories com_contact com_fields | ⇒ | Modules Front End |
The only difference is that it is rendered by JLayout which allows users to create an override.
Am I being daft here but you could always create an override for the module output. But now if you want to create an override then it will impact not just the image layout in the module but everywhere that the image layout is being used.
The only difference is that it is rendered by JLayout which allows users to create an override.
Am I being daft here but you could always create an override for the module output. But now if you want to create an override then it will impact not just the image layout in the module but everywhere that the image layout is being used.
isn't that great?
The JLayout perfect spot to implement a cdn for images.
It is up to the JLayout how images should be rendered, not the module.
The module should forward the information to the JLayout to render the image.
I have tested this item ✅ successfully on a1ba0fa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42508.
| Labels |
Added:
Feature
PBF
Removed: Unit/System Tests |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42508.
I have tested this item ✅ successfully on 0b6155a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42508.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-28 21:36:37 |
| Closed_By | ⇒ | bembelimen |
Thanks
I have tested this item ✅ successfully on a1ba0fa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42508.