[#42485] - Set correct AssetTitle and AssetParentId
- Closed
- 11 Dec 2023
- Medium
- Build: 5.0-dev
- # 42485
- Diff
- sanderpotjer:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #42484.
Summary of Changes
Currently the asset title and parent asset id are not set for the Scheduled Tasks, so ending up incorrectly in the database. This PR sets the correct values for both
Testing Instructions
- Check #__assets database table for the scheduled taks and not the incorrect title and parent ID
- Open Tasks via admin, re-save them
- Check #__assets database table for the scheduled taks and notice the correct title and parent ID are set
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
PR-5.0-dev
|
||
Are you familiar with nested tables so you know how to change the lft and rgt values?
You could find some information on that here: https://en.wikipedia.org/wiki/Nested_set_model
The following presentation by P. Martin may be an addition, link https://www.youtube.com/watch?v=YCs6YD_H14c&t=783s
The following presentation by P. Martin may be an addition, link https://www.youtube.com/watch?v=YCs6YD_H14c&t=783s
@sandewt I am familiar with nested tables so won't need that video.
@sanderpotjer Another thing: As it turns out, this PR is good as it is, but it should be made for 4.4-dev as it is a bug fix. It will then later be merged up into 5.0-dev by maintainers. In 4.4-dev we do not have any task assets yet for new installations, so the PR is good as it is. In 5.0-dev it would need a separate follow-up PR when this one has been merged up, which will handle the base.sql changes. I can do that later when it is the time.
@richard67 thanks for the feedback!
I'm familiar with nested tables, actually have a tool that generates the perfect #__assets table values.
If tried to correct the installation/sample data multiple times in the past, but of course outdated by the time someone looks at it. So also the reason I did not include changes on that area in this PR. This is a bug fix of code that asset-wise should not have been merged in the first place. So glad you changed mind that the installation sql changes are not needed for this PR ?
Created a new PR for 4.4-dev: #42493
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-12-11 08:27:42 |
| Closed_By | ⇒ | sanderpotjer |
sorry for the mistake,. must remember not ton post if I have not slept in 24hrs