[#42451] - [5] install from CLI deprecation php 8
- Fixed in Code Base
- 13 Dec 2023
- Medium
- Build: 5.0-dev
- # 42451
- Diff
- alikon:patch-21
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #42436 .
Summary of Changes
declare $clientId
Testing Instructions
Install Joomla via CLI with PHP 8.x
php installation/joomla.php install --site-name="My Site name" --admin-user="Some name" --admin-username="admin" --admin-password="qwertyuiop123" --admin-email="your@emailaddress.nl" --db-type="mysqli" --db-host="localhost" --db-user="root" --db-pass="" --db-name="demoDB" --db-prefix="demo_" --db-encryption="0"
Actual result BEFORE applying this Pull Request
Deprecated: Creation of dynamic property Joomla\CMS\Installation\Application\CliInstallationApplication::$clientId is deprecated in ...\installation\src\Application\CliInstallationApplication.php on line 107
Expected result AFTER applying this Pull Request
no more deprecation
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42451.
Although the fix looks good, why is this RTC without two tests?
Issue trackers shows 2 successful tests though... https://issues.joomla.org/tracker/joomla-cms/42451
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-12-13 14:15:08 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
PHP 8.x
PR-5.0-dev
|
||
Thx
Thx @alikon
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42451.
Thanks for the PR @alikon Maybe line 115: $this->clientId = 2; can be removed instead?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42451.