Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42423] - [5.1] Use Dialog for Module editing

Feature RTC NPM Resource Changed PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
29 Nov 2023

Summary of Changes

Use Dialog for module editing modals.

Affects:

  • Dashboard: add module
  • Menus: add/edit module
  • Menu item: Module Assignment tab

Any other place I forgot?

Testing Instructions

Run npm install,

Test:

  • Dashboard: add module
  • Menus: add/edit module
  • Menu item, in Module Assignment tab: edit module

Actual result BEFORE applying this Pull Request

Works with BS modal

Expected result AFTER applying this Pull Request

Works with new dialog

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: joomla/Manual#208
  • No documentation changes for manual.joomla.org needed

References:

avatar Fedik Fedik - open - 29 Nov 2023
avatar Fedik Fedik - change - 29 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Nov 2023
Category ⇒ Administration com_cpanel com_menus com_modules JavaScript Repository NPM Change Libraries
avatar Fedik Fedik - change - 29 Nov 2023
The description was changed
avatar Fedik Fedik - edited - 29 Nov 2023
avatar Fedik Fedik - change - 29 Nov 2023
Labels Added: NPM Resource Changed PR-5.1-dev
avatar Fedik Fedik - change - 30 Nov 2023
Labels Added: Feature
avatar Fedik Fedik - change - 30 Nov 2023
The description was changed
avatar Fedik Fedik - edited - 30 Nov 2023
avatar Fedik Fedik - change - 2 Dec 2023
The description was changed
avatar Fedik Fedik - edited - 2 Dec 2023
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2024
Category Administration com_cpanel com_menus com_modules JavaScript Repository NPM Change Libraries ⇒ Administration com_cpanel com_menus com_modules Repository NPM Change JavaScript
avatar fgsw fgsw - test_item - 11 Jan 2024 - Tested successfully
avatar fgsw
fgsw - comment - 11 Jan 2024

I have tested this item ✅ successfully on 25f275f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42423.

avatar Quy Quy - test_item - 13 Jan 2024 - Tested successfully
avatar Quy
Quy - comment - 13 Jan 2024

I have tested this item ✅ successfully on 25f275f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42423.

avatar Quy Quy - change - 13 Jan 2024
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 13 Jan 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42423.

avatar Quy Quy - change - 13 Jan 2024
Labels Added: RTC

Add a Comment

Login with GitHub to post a comment