Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42346] - [5.0] Fix URLs and hardcoded keyName for editing URL, in ModalSelectField

? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
15 Nov 2023

Pull Request for Issue # .

Summary of Changes

Adds Route::_() for URLs to make sure they are corectly prefixed with a base URL.
Fix hardoced keyName id to allow other var name.

Testing Instructions

Run npm install

Add the field somewhere, example in mod_custom:

<field 
    type="ModalSelect"
    name="test"
    label="Test"
    default="1"
    urlSelect="index.php?tmpl=component"
    urlEdit="index.php?tmpl=component"
    edit="true"
    data-key-name="foo"
/>

Then open the form and click Edit button.
Check the popup content.
Also check the iframe url, in the browser console.

Actual result BEFORE applying this Pull Request

Depend from installation, you wil get 404 not found (for installations in subfolder) or home page.
Iframe url containe &id=1

Expected result AFTER applying this Pull Request

You get dashboard in popup.
Iframe url containe &foo=1

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference;

avatar Fedik Fedik - open - 15 Nov 2023
avatar Fedik Fedik - change - 15 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Nov 2023
Category ⇒ JavaScript Repository NPM Change Layout
avatar Fedik Fedik - change - 15 Nov 2023
Title
…
[5.0] Fix URLs and hardoced keyName for editing URL
[5.0] Fix URLs and hardoced keyName for editing URL, in ModalSelectField
avatar Fedik Fedik - edited - 15 Nov 2023
avatar Fedik Fedik - change - 15 Nov 2023
Title
…
[5.0] Fix URLs and hardoced keyName for editing URL, in ModalSelectField
[5.0] Fix URLs and hardcoded keyName for editing URL, in ModalSelectField
avatar Fedik Fedik - edited - 15 Nov 2023
avatar Fedik Fedik - change - 15 Nov 2023
The description was changed
avatar Fedik Fedik - edited - 15 Nov 2023
avatar Fedik Fedik - change - 15 Nov 2023
The description was changed
avatar Fedik Fedik - edited - 15 Nov 2023
avatar HLeithner
HLeithner - comment - 15 Nov 2023

thanks, really appreciated.

avatar Fedik Fedik - change - 15 Nov 2023
The description was changed
avatar Fedik Fedik - edited - 15 Nov 2023
avatar HLeithner HLeithner - test_item - 18 Nov 2023 - Tested successfully
avatar HLeithner
HLeithner - comment - 18 Nov 2023

I have tested this item ✅ successfully on e10dd4a

works as expected

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42346.

avatar chmst chmst - test_item - 18 Nov 2023 - Tested successfully
avatar chmst
chmst - comment - 18 Nov 2023

I have tested this item ✅ successfully on e10dd4a

Tested following testing instructions. Works as described.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42346.

avatar chmst chmst - change - 18 Nov 2023
Status Pending ⇒ Ready to Commit
avatar chmst
chmst - comment - 18 Nov 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42346.

avatar bembelimen bembelimen - change - 18 Nov 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-11-18 11:50:13
Closed_By ⇒ bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 18 Nov 2023
avatar bembelimen bembelimen - merge - 18 Nov 2023
avatar bembelimen
bembelimen - comment - 18 Nov 2023

Thx

Add a Comment

Login with GitHub to post a comment