Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42334] - [5.1] Subform rows sorting with buttons, addittionaly to drag and drop

Feature RTC Language Change NPM Resource Changed PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
11 Nov 2023

Summary of Changes

Add posibility to sort subform rows with buttons "up" and "down".
Useful for large forms.

Screenshot 2023-11-11_20-58-38

Fix for #39092

Testing Instructions

Run npm install
Create a subform somewhere:

<field type="subform" name="subform" label="subform" multiple="true">
  <form>
    <field type="text" name="text" label="Text"/>
  </form>
</field>

And use new up/down button for rows sorting

Actual result BEFORE applying this Pull Request

nothing

Expected result AFTER applying this Pull Request

works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 11 Nov 2023
avatar Fedik Fedik - change - 11 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2023
Category ⇒ JavaScript Repository NPM Change Layout
89a503e 11 Nov 2023 avatar Fedik Text
avatar Fedik Fedik - change - 11 Nov 2023
Labels Added: NPM Resource Changed PR-5.1-dev
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2023
Category JavaScript Repository NPM Change Layout ⇒ Administration Language & Strings JavaScript Repository NPM Change Layout
avatar Quy Quy - test_item - 12 Nov 2023 - Tested successfully
avatar Quy
Quy - comment - 12 Nov 2023

I have tested this item ✅ successfully on 89a503e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42334.

avatar AndySDH
AndySDH - comment - 12 Nov 2023

This approach is a bit reductive and I don't feel like it fully addresses #39092. Dragging and dropping is still very bad, and I don't think adding an up and down arrow is enough to call the problem solved...

avatar viocassel viocassel - test_item - 13 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 13 Nov 2023

I have tested this item ✅ successfully on 89a503e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42334.

avatar Quy Quy - change - 13 Nov 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 13 Nov 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42334.

avatar Quy Quy - change - 16 Dec 2023
Labels Added: Feature RTC
avatar Razzo1987 Razzo1987 - change - 28 Dec 2023
Labels Added: Language Change
avatar LadySolveig LadySolveig - close - 12 Jan 2024
avatar LadySolveig LadySolveig - merge - 12 Jan 2024
avatar LadySolveig LadySolveig - change - 12 Jan 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-01-12 08:11:31
Closed_By ⇒ LadySolveig
avatar LadySolveig
LadySolveig - comment - 12 Jan 2024

A heartfelt thanks @Fedik and thanks to the testers @viocassel @Quy

Add a Comment

Login with GitHub to post a comment