? NPM Resource Changed bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
7 Nov 2023

Pull Request for Issue #42304 .

Summary of Changes

The error hapen because toggleButton is not available on mobile, and script crashes.

Testing Instructions

Run npm install
Open Article editing on mobile

Actual result BEFORE applying this Pull Request

TinyMCE does not work

Expected result AFTER applying this Pull Request

TinyMCE works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 7 Nov 2023
avatar Fedik Fedik - change - 7 Nov 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2023
Category JavaScript Repository NPM Change
avatar HLeithner HLeithner - test_item - 7 Nov 2023 - Tested successfully
avatar HLeithner
HLeithner - comment - 7 Nov 2023

I have tested this item ✅ successfully on 97bb63a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42306.

avatar Quy Quy - test_item - 7 Nov 2023 - Tested successfully
avatar Quy
Quy - comment - 7 Nov 2023

I have tested this item ✅ successfully on 97bb63a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42306.

avatar Quy Quy - change - 7 Nov 2023
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug PR-5.0-dev
avatar Quy
Quy - comment - 7 Nov 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42306.

avatar laoneo laoneo - change - 8 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-08 06:32:17
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 8 Nov 2023
avatar laoneo laoneo - merge - 8 Nov 2023
avatar laoneo
laoneo - comment - 8 Nov 2023

Thanks!

Add a Comment

Login with GitHub to post a comment