Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42294] - [5.0] Cassiopeia should respect inheritance

? bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
5 Nov 2023

Pull Request for Issue #42260 .

Summary of Changes

  • The code for the Colour Theme should respect inheritance and allow overrides, right now it's hardcoded to the parent template

Testing Instructions

  • Apply the patch
  • Check that the Colour Theme value is respected
  • Create a child template test
  • Create a file media/templates/site/cassiopeia_test/css/global/colors_standard.css and a file media/templates/site/cassiopeia_test/css/global/colors_standard.min.css with contents:
:root {
  --cassiopeia-color-primary: rebeccapurple;
  --cassiopeia-color-link: rebeccapurple;
  --link-color: rebeccapurple;
  --link-color-rgb: 34, 79, 170;
  --cassiopeia-color-hover: rebeccapurple;
}

Check that when the field Colour Theme has a value standard the template has a purple colour for the links and header

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@astridx

avatar dgrammatiko dgrammatiko - open - 5 Nov 2023
avatar dgrammatiko dgrammatiko - change - 5 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Nov 2023
Category ⇒ Front End Templates (site)
avatar dgrammatiko dgrammatiko - change - 5 Nov 2023
Labels Added: bug PR-5.0-dev
avatar Fedik Fedik - test_item - 5 Nov 2023 - Tested successfully
avatar Fedik
Fedik - comment - 5 Nov 2023

I have tested this item ✅ successfully on 5234af2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42294.

avatar astridx astridx - test_item - 5 Nov 2023 - Tested successfully
avatar astridx
astridx - comment - 5 Nov 2023

I have tested this item ✅ successfully on 5234af2

Thank you very much @dgammatiko

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42294.

avatar alikon alikon - change - 5 Nov 2023
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 5 Nov 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42294.

avatar HLeithner HLeithner - change - 6 Nov 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-11-06 08:25:00
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 6 Nov 2023
avatar HLeithner HLeithner - merge - 6 Nov 2023
avatar HLeithner
HLeithner - comment - 6 Nov 2023

thanks

Add a Comment

Login with GitHub to post a comment