Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42293] - [5.1] Use Dialog field for Modal_Category

Feature ? PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
5 Nov 2023

Summary of Changes

Changing Modal_Category field to use new modal dialog.
The same as #40462 but for Category.

Testing Instructions

Create a menu for category,
Select/edit value in "Choose a Category" field

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: joomla/Manual#178
  • No documentation changes for manual.joomla.org needed

Reference:

avatar Fedik Fedik - open - 5 Nov 2023
avatar Fedik Fedik - change - 5 Nov 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Nov 2023
Category ⇒ Administration com_categories
avatar Fedik
Fedik - comment - 5 Nov 2023

Will rebase it later, currently there some conflict with dron file.

avatar Fedik Fedik - change - 5 Nov 2023
Title
…
[5.1] Modal field for Modal_Category
[5.1] Use Dialog field for Modal_Category
avatar Fedik Fedik - edited - 5 Nov 2023
avatar Fedik Fedik - change - 6 Nov 2023
Labels Added: Feature PR-5.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2023
Category Administration com_categories ⇒ Unit Tests Repository Administration com_categories com_fields com_installer JavaScript com_media NPM Change com_templates Language & Strings
avatar Fedik Fedik - change - 6 Nov 2023
Labels Added: NPM Resource Changed PR-5.1-dev
Removed: PR-5.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2023
Category Administration com_categories Unit Tests Repository com_fields com_installer JavaScript com_media NPM Change com_templates Language & Strings ⇒ Administration com_categories
avatar LadySolveig LadySolveig - change - 7 Nov 2023
Labels Removed: NPM Resource Changed
avatar Quy Quy - test_item - 7 Nov 2023 - Tested successfully
avatar Quy
Quy - comment - 7 Nov 2023

I have tested this item ✅ successfully on 88cb998

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42293.

avatar viocassel viocassel - test_item - 10 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 10 Nov 2023

I have tested this item ✅ successfully on 88cb998

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42293.

avatar Quy Quy - change - 10 Nov 2023
The description was changed
Status Pending ⇒ Ready to Commit
avatar Quy Quy - edited - 10 Nov 2023
avatar Quy
Quy - comment - 10 Nov 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42293.

avatar LadySolveig LadySolveig - change - 13 Nov 2023
Labels Added: ?
avatar LadySolveig LadySolveig - change - 13 Nov 2023
Labels Added: ?
Removed: ?
avatar LadySolveig LadySolveig - change - 14 Nov 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-11-14 09:19:52
Closed_By ⇒ LadySolveig
Labels Added: ?
Removed: ?
avatar LadySolveig LadySolveig - close - 14 Nov 2023
avatar LadySolveig LadySolveig - merge - 14 Nov 2023
avatar LadySolveig
LadySolveig - comment - 14 Nov 2023

Thank you @Fedik !
And thanks to the diligent testers @viocassel @Quy

Add a Comment

Login with GitHub to post a comment