Feeling Lucky
Feature
?
Conflicting Files
NPM Resource Changed
PR-5.0-dev
[#42265] - [5.x] Switch to Node 20
- Closed
- 15 Nov 2023
- Medium
- Build: 5.0-dev
- # 42265
- Diff
- dgrammatiko:5.0-dev-node20
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Node 18 Active Support ended 2 weeks ago (18 Oct 2023), so switching to 20
Added.npmrcso the node version is strict- Added missing
semverpackage in the devDependencies - use the helper handleErr fn
- Added a runtime conditional and a message for incompatible node versions
Testing Instructions
Run npm ci, everything still works
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository JavaScript NPM Change |
| Labels |
Added:
?
NPM Resource Changed
PR-5.0-dev
|
||
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-15 17:47:06 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
Feature
?
Conflicting Files
Removed: ? |
||
dgrammatiko
- comment
- 15 Nov 2023
This can be closed although there are some mistakes that need fixing. Will do a pr once I get some free time
Hey @dgrammatiko would you please check the upmerge #42345 if this resolved this PR or if something is missing? Thanks!