@test all good after applying the patch, 2FA works as expected and post install messages still work.

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

Thank you, Roland!

While trying to merge this I realised it was sent vs staging branch and a previous version has already been merged into 3.4-dev (where this should go).

Is it possible that you send a PR against 3.4-dev? so I avoid dealing with all the conflicts found while trying to merge.

Thanks.

For reasons I cannot understand, when I try to do the PR against dev-3.4 it tells me I am doing a PR for 89 commit and 809 changed files when, in fact, it's just one commit and a dozen files. I've tried 3 times the last 20 minutes. As I don't have more time to waste on GitHub being braindead, you can simply copy the libraries/fof directory and administrator/manifests/library/fof.xml from my PR to the dev branch.

@nikosdion I can at least tell you why you get this.
Since you likely rebased your branch now to 3.4, and the PR is against the staging branch, it will list all changes between them. That gives you those 89 commits and 800 changed files.

Unfortunately you can't change the target branch of a PR after you created it. So you need to close this one and create a new one. In the form where you create the new PR, you can edit the target branch and set it to 3.4-dev.

New PR at:
#4233

I think everything should be there. Please @nikosdion can you confirm it?

Closing this.