[#42199] - fix #42191 Unknown column 'id' in 'field list'
- Fixed in Code Base
- 3 Nov 2023
- Medium
- Build: 4.4-dev
- # 42199
- Diff
- svanschu:4.4-dev
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
In this method it tries to load the field 'id' from the extensions table. But there isn't any field called id in this table. The id field for the extenions table is called extension_id
Pull Request for Issue # .
Summary of Changes
Moved the select id statement into the module if clause and create a new select extension_id as id clause for the else branch
Testing Instructions
class testingInstallerScript extends InstallerScript
{
public function postflight($type, $parent)
{
$extid = $this->getInstances(false);
}
}
Actual result BEFORE applying this Pull Request
Unknown column 'id' in 'field list'
Expected result AFTER applying this Pull Request
successfully return extension id in an array
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
wow nobody noticed this issue in the at least last 7 years?
wow nobody noticed this issue in the at least last 7 years?
Or just overriden the method without fixing the source. Or just done it on it's own.
I only noticed the method because I wanted to know what is all available and read the class code. It's as well the first time I ever used it.
I have tested this item ✅ successfully on dca2c7e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42199.
I have tested this item ✅ successfully on dca2c7e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42199.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-4.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42199.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-03 13:05:18 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
Removed: ? |
||
Thanks!
@richard67 as suggested the PR for 4.4-dev