[#42197] - [5.0] Event PrepareModuleList use "loaded" flag
- Closed
- 31 Oct 2023
- Medium
- Build: 5.0-dev
- # 42197
- Diff
- Fedik:event-prep-modules-loaded
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #42149 .
Summary of Changes
Kind of b/c fix.
Adding a "loaded" flag to be able to distinct initialised $modules array from empty.
And fixed some comments.
Testing Instructions
Add to sytem plugin the event listener:
public function onPrepareModuleList(\Joomla\CMS\Event\Module\PrepareModuleListEvent $event)
{
$event->updateModules([]);
$event->setLoaded(true);
}Example add it around here
joomla-cms/plugins/system/sef/src/Extension/Sef.php
Lines 26 to 27 in 4c799de
And visit the site page.
Actual result BEFORE applying this Pull Request
All modules is rendered
Expected result AFTER applying this Pull Request
No modules is rendered, only content is rendered
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have updated description
what should I look for before and after applying the patch
Any page, can be also administrator. you will notice when the modules will disappear ?
After applying the patch, with the code inserted as suggested I see all of the frontend and backend modules have disappeared. However, I don't really know enough to be aware of any possible side effects. Better for me to leave testing to someone else!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42197.
I'm not really happy with the solution, I'm also not convinced that this is needed at all. It might be better done in some temp storage/variable for the current rendering. Also other plugins have to understand this behavior which sounds at least to me very uncommon.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-31 11:31:36 |
| Closed_By | ⇒ | Fedik | |
| Labels |
Added:
Feature
bug
PR-5.0-dev
|
||
See: #42149 (comment)
Sorry, I do not understand exactly how to test. I have a test site clone of joomla-cms with 5 checked out and test data installed. Exactly which plugin should that code be added to and exactly what should I look for before and after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42197.