? Release Blocker NPM Resource Changed bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
9 Oct 2023

Pull Request for Issue #42087 (comment) .

Summary of Changes

The language option has values separated with :, but the JS code was looking for |.

$options[$langCode]->value = $language->lang_code . ':' . $itemId . ':edit';

Testing Instructions

Run npm install
Edit association "side by side" for existing association,
Push "clear" button

Actual result BEFORE applying this Pull Request

Nothing happen

Expected result AFTER applying this Pull Request

Association removed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 9 Oct 2023
avatar Fedik Fedik - change - 9 Oct 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Oct 2023
Category JavaScript Repository NPM Change
avatar Fedik Fedik - change - 9 Oct 2023
The description was changed
avatar Fedik Fedik - edited - 9 Oct 2023
avatar richard67 richard67 - test_item - 9 Oct 2023 - Tested successfully
avatar richard67
richard67 - comment - 9 Oct 2023

I have tested this item ✅ successfully on ce44c8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42098.

avatar alikon alikon - test_item - 9 Oct 2023 - Tested successfully
avatar alikon
alikon - comment - 9 Oct 2023

I have tested this item ✅ successfully on ce44c8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42098.

avatar alikon
alikon - comment - 9 Oct 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42098.

avatar richard67 richard67 - change - 9 Oct 2023
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug Release Blocker PR-5.0-dev
avatar richard67
richard67 - comment - 9 Oct 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42098.

avatar HLeithner HLeithner - close - 9 Oct 2023
avatar HLeithner HLeithner - merge - 9 Oct 2023
avatar HLeithner HLeithner - change - 9 Oct 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-10-09 14:17:31
Closed_By HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 9 Oct 2023

Thx

Add a Comment

Login with GitHub to post a comment