Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42090] - [5.1] Deprecate app/db properties in ActionLogPlugin

Feature PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
8 Oct 2023

Summary of Changes

deprecate $app and $db property in ActionLogPlugin and their possible use replaced

I'm not sure about the horizon (J6.0 or J7.0) of the removal of the properties

Testing Instructions

check action logs are still working

Actual result BEFORE applying this Pull Request

deprecation messages are logged

joomla-cms/libraries/src/Plugin/CMSPlugin.php

Line 138 in bd79fd3

@trigger_error('The application should be injected through setApplication() and requested through getApplication().', E_USER_DEPRECATED);

joomla-cms/libraries/src/Plugin/CMSPlugin.php

Line 148 in bd79fd3

@trigger_error('The database should be injected through the DatabaseAwareInterface and trait.', E_USER_DEPRECATED);

Expected result AFTER applying this Pull Request

deprecation messages are still logged, but properties are no longer used and now themselves deprecated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#210

avatar heelc29 heelc29 - open - 8 Oct 2023
avatar heelc29 heelc29 - change - 8 Oct 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2023
Category ⇒ Administration
avatar laoneo
laoneo - comment - 8 Oct 2023

If you do it in 5.0,then the removal must be 7.0.

avatar heelc29
heelc29 - comment - 8 Oct 2023

So the code to set the properties (in CMSPlugin) is not removed before 7.0?

avatar heelc29 heelc29 - change - 8 Oct 2023
Labels Added: PR-5.1-dev
avatar HLeithner
HLeithner - comment - 23 Nov 2023

So the code to set the properties (in CMSPlugin) is not removed before 7.0?

yes next+1 major version

avatar HLeithner
HLeithner - comment - 23 Nov 2023

also can you please create a deprecation entry in https://manual.joomla.org/migrations/50-51/new-deprecations

avatar heelc29 heelc29 - change - 18 Dec 2023
Labels Added: Feature
avatar heelc29 heelc29 - change - 18 Dec 2023
The description was changed
avatar heelc29 heelc29 - edited - 18 Dec 2023
avatar heelc29
heelc29 - comment - 18 Dec 2023

also can you please create a deprecation entry in https://manual.joomla.org/migrations/50-51/new-deprecations

Done. joomla/Manual#210

avatar laoneo
laoneo - comment - 19 Dec 2023

So the code to set the properties (in CMSPlugin) is not removed before 7.0?

If we will do that, then we still can copy the code to this class to support the properties till 7.0. But I doubt that we go to remove the code in CMSPlugin in 7.0.

avatar HLeithner
HLeithner - comment - 21 Jan 2024

@laoneo there is no reason to not merge this right?

avatar bembelimen bembelimen - test_item - 4 Mar 2024 - Tested successfully
avatar bembelimen
bembelimen - comment - 4 Mar 2024

I have tested this item ✅ successfully on 4fbb778

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42090.

avatar laoneo laoneo - test_item - 4 Mar 2024 - Tested successfully
avatar laoneo
laoneo - comment - 4 Mar 2024

I have tested this item ✅ successfully on 4fbb778

Tested with the action log plugin of DPCalendar.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42090.

avatar LadySolveig LadySolveig - close - 4 Mar 2024
avatar LadySolveig LadySolveig - merge - 4 Mar 2024
avatar LadySolveig LadySolveig - change - 4 Mar 2024
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-03-04 12:44:48
Closed_By ⇒ LadySolveig
avatar LadySolveig
LadySolveig - comment - 4 Mar 2024

Thank you @heelc29

Add a Comment

Login with GitHub to post a comment