[#42089] - [5.0] Fix SCSS CS broken by PR #42078
- Fixed in Code Base
- 8 Oct 2023
- Medium
- Build: 5.0-dev
- # 42089
- Diff
- richard67:5.0-dev-fix-broken-scss-cs
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Fix broken scss-cs test in drone caused by PR #42078 .
I only can recommend to use editors which show white space (tabs and spaces), like e.g. notepad++, or to adjust your IDE to show them or to use a good editor. And maybe switch off automatic indentation on new lines in your editor because that is what causes this issue (spaces in empty lines).
And to maintainers or release managers I only can recommend to check drone and appveyor logs before merging PRs.
Testing Instructions
Check logs of the scss-cs step in drone.
Actual result BEFORE applying this Pull Request
The scss-cs step fails in drone for the 5.0-dev branch since PR #42078 has been merged.
Expected result AFTER applying this Pull Request
The scss-cs step succeeds in drone for the branch of this PR.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-08 09:53:56 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||