Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42058] - [5.0] Console error due to missing dependency

? Release Blocker bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
5 Oct 2023

Pull Request for Issue #42056 .

Summary of Changes

Add the missing dependency in the view

Testing Instructions

Follow the issue #42056

Actual result BEFORE applying this Pull Request

Console error, side commands don't do anything

Expected result AFTER applying this Pull Request

Side commands work as expected

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar dgrammatiko dgrammatiko - open - 5 Oct 2023
avatar dgrammatiko dgrammatiko - change - 5 Oct 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2023
Category ⇒ Administration
avatar dgrammatiko dgrammatiko - change - 5 Oct 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 5 Oct 2023
avatar Quy Quy - test_item - 5 Oct 2023 - Tested successfully
avatar Quy
Quy - comment - 5 Oct 2023

I have tested this item ✅ successfully on 0dfdeae

Thank you!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42058.

avatar Fedik
Fedik - comment - 5 Oct 2023

Please add the dependency to media/com_mails/joomla.asset.json instead, it will be more safe

avatar dgrammatiko dgrammatiko - change - 5 Oct 2023
Labels Added: Release Blocker bug PR-5.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2023
Category Administration ⇒ Repository NPM Change
avatar Fedik Fedik - test_item - 5 Oct 2023 - Tested successfully
avatar Fedik
Fedik - comment - 5 Oct 2023

I have tested this item ✅ successfully on c7d9d07

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42058.

avatar Quy Quy - test_item - 5 Oct 2023 - Tested successfully
avatar Quy
Quy - comment - 5 Oct 2023

I have tested this item ✅ successfully on c7d9d07

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42058.

avatar Quy Quy - change - 5 Oct 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 5 Oct 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42058.

avatar dgrammatiko dgrammatiko - change - 5 Oct 2023
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2023
Category Repository NPM Change ⇒ Administration Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 5 Oct 2023
Labels Added: NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2023
Category Repository NPM Change Administration ⇒ Administration
avatar dgrammatiko
dgrammatiko - comment - 5 Oct 2023

Sorry @Fedik @Quy I just figure out that the problem was the type of the field, not a forgotten dependency. So Fedir was right that some dependency was missing but that was because the field was wrongly set as textarea instead of editor. Can you please retest?

avatar Quy Quy - test_item - 5 Oct 2023 - Tested successfully
avatar Quy
Quy - comment - 5 Oct 2023

I have tested this item ✅ successfully on d347c86

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42058.

avatar HLeithner HLeithner - change - 5 Oct 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-10-05 14:38:17
Closed_By ⇒ HLeithner
Labels Removed: NPM Resource Changed
avatar HLeithner HLeithner - close - 5 Oct 2023
avatar HLeithner HLeithner - merge - 5 Oct 2023
avatar HLeithner
HLeithner - comment - 5 Oct 2023

thanks

Add a Comment

Login with GitHub to post a comment