Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42057] - [5.0] Treeselect dark mode

? NPM Resource Changed PR-5.0-dev Dark Mode Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Oct 2023

Pull Request for Issue #42055 .

Summary of Changes

menu name is visible in both light and dark modes

Testing Instructions

npm run build:css

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 5 Oct 2023
avatar brianteeman brianteeman - change - 5 Oct 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2023
Category ⇒ Repository NPM Change
avatar Quy Quy - test_item - 5 Oct 2023 - Tested successfully
avatar Quy
Quy - comment - 5 Oct 2023

I have tested this item ✅ successfully on 7726083

Header fixed, however, the vertical line is barely visible.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42057.

avatar dgrammatiko dgrammatiko - test_item - 5 Oct 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 5 Oct 2023

I have tested this item ✅ successfully on 7726083

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42057.

avatar alikon alikon - change - 5 Oct 2023
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 5 Oct 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42057.

avatar wilsonge
wilsonge - comment - 5 Oct 2023

@brianteeman can you fix the tree color as @Quy mentioned as part of this please.

avatar brianteeman
brianteeman - comment - 5 Oct 2023

yes - i didnt see it amongst all the text in his bug report

avatar brianteeman brianteeman - change - 5 Oct 2023
Labels Added: ? NPM Resource Changed PR-5.0-dev Dark Mode
avatar brianteeman
brianteeman - comment - 5 Oct 2023

Done (I hope)

image

image

avatar Quy Quy - test_item - 5 Oct 2023 - Tested successfully
avatar Quy
Quy - comment - 5 Oct 2023

I have tested this item ✅ successfully on c3d5116

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42057.

avatar dgrammatiko dgrammatiko - test_item - 6 Oct 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 6 Oct 2023

I have tested this item ✅ successfully on c3d5116

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42057.

avatar HLeithner HLeithner - change - 6 Oct 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-10-06 12:37:34
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 6 Oct 2023
avatar HLeithner HLeithner - merge - 6 Oct 2023
avatar brianteeman
brianteeman - comment - 6 Oct 2023

Thanks

Add a Comment

Login with GitHub to post a comment