User tests: Successful: Unsuccessful:
Pull request for #42013
btn-inverse was not setup in the toolbar css
as this is an scss change you will need to either use a prebuilt package or npm run build:css
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Repository NPM Change |
This is fine but btn-inverse
is an old bs2 class that was removed in bs3+ so we might be better off just changing the class to one of our existing classes rather than reintroducing it.
Good point - I will change the class instead
Labels |
Added:
Release Blocker
NPM Resource Changed
bug
PR-5.0-dev
|
Category | Repository NPM Change | ⇒ | Administration com_content com_contenthistory |
Updated as suggested
Haven't tested. But if this works looks like a better fix!
I have tested this item ✅ successfully on 15f583e
I have tested this item ✅ successfully on 15f583e
Using the prebuild update package
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-06 12:38:25 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
Dark Mode
Removed: Release Blocker NPM Resource Changed |
Thanks
@wilsonge would like a approval from you for this change, thanks