Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42051] - [5.0] Dark Mode: Versions toolbar

? bug PR-5.0-dev Dark Mode Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Oct 2023

Pull request for #42013

Summary of Changes

btn-inverse was not setup in the toolbar css

Testing Instructions

as this is an scss change you will need to either use a prebuilt package or npm run build:css

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

No change in light mode
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 5 Oct 2023
avatar brianteeman brianteeman - change - 5 Oct 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2023
Category ⇒ Repository NPM Change
avatar HLeithner
HLeithner - comment - 5 Oct 2023

@wilsonge would like a approval from you for this change, thanks

avatar wilsonge
wilsonge - comment - 5 Oct 2023

This is fine but btn-inverse is an old bs2 class that was removed in bs3+ so we might be better off just changing the class to one of our existing classes rather than reintroducing it.

avatar brianteeman
brianteeman - comment - 5 Oct 2023

Good point - I will change the class instead

avatar brianteeman brianteeman - change - 5 Oct 2023
Labels Added: Release Blocker NPM Resource Changed bug PR-5.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2023
Category Repository NPM Change ⇒ Administration com_content com_contenthistory
avatar brianteeman
brianteeman - comment - 5 Oct 2023

Updated as suggested

avatar wilsonge
wilsonge - comment - 5 Oct 2023

Haven't tested. But if this works looks like a better fix!

avatar HLeithner
HLeithner - comment - 5 Oct 2023

@MacJoom or anyone else can we get a test here please.

avatar Quy Quy - test_item - 5 Oct 2023 - Tested successfully
avatar Quy
Quy - comment - 5 Oct 2023

I have tested this item ✅ successfully on 15f583e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42051.

avatar MacJoom MacJoom - test_item - 5 Oct 2023 - Tested successfully
avatar MacJoom
MacJoom - comment - 5 Oct 2023

I have tested this item ✅ successfully on 15f583e

Using the prebuild update package

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42051.

avatar Quy Quy - change - 5 Oct 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 5 Oct 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42051.

avatar Quy Quy - change - 5 Oct 2023
Labels Added: ?
avatar HLeithner HLeithner - change - 6 Oct 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-10-06 12:38:25
Closed_By ⇒ HLeithner
Labels Added: Dark Mode
Removed: Release Blocker NPM Resource Changed
avatar HLeithner HLeithner - close - 6 Oct 2023
avatar HLeithner HLeithner - merge - 6 Oct 2023
avatar brianteeman
brianteeman - comment - 6 Oct 2023

Thanks

Add a Comment

Login with GitHub to post a comment