Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42050] - [5.0] dark mode - quickicon amount

Release Blocker NPM Resource Changed bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Oct 2023

Pull Request for Issue #42045

Summary of Changes

The count of items was not visible when in dark mode

Testing Instructions

For a quickicon change the option to include shopwing the count
Switch to dark mode

as this is an scss change you will need to either use a prebuilt package or npm run build:css

Actual result BEFORE applying this Pull Request

Count is white text on a white background

image

Expected result AFTER applying this Pull Request

image

No change to light mode

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 5 Oct 2023
avatar brianteeman brianteeman - change - 5 Oct 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2023
Category ⇒ Repository NPM Change
avatar brianteeman brianteeman - change - 5 Oct 2023
The description was changed
avatar brianteeman brianteeman - edited - 5 Oct 2023
avatar HLeithner
HLeithner - comment - 5 Oct 2023

@wilsonge would like a approval from you for this change, thanks

avatar HLeithner HLeithner - change - 5 Oct 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-10-05 11:16:26
Closed_By ⇒ HLeithner
Labels Added: Release Blocker NPM Resource Changed bug PR-5.0-dev
avatar HLeithner HLeithner - close - 5 Oct 2023
avatar HLeithner HLeithner - merge - 5 Oct 2023

Add a Comment

Login with GitHub to post a comment