[#42038] - [5.0] hash the urls inside css files
- Fixed in Code Base
- 5 Oct 2023
- Medium
- Build: 5.0-dev
- # 42038
- Diff
- dgrammatiko:5.0-dev-cssInv
User tests: Successful: Unsuccessful:
Pull Request for Issue #42028 a redo of #32574.
Summary of Changes
- Adds cache invalidation for all the
url()parts of static CSS - New script entry for the package.json
- Added in the build.php
Testing Instructions
- Get a clean clone of the repo
- run
composer installandnpm install - run the command
npm run cssversioning
Actual result BEFORE applying this Pull Request
urls paths don't have an invalidation string
Expected result AFTER applying this Pull Request
urls paths do have an invalidation string
Verification:
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
This affects only the released packages, so more or less it's only affecting the release teams
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
can we get the version string short 5 to match the other new autogenerated version strings?
I have tested this item ✅ successfully on 9d52aaf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42038.
| Labels |
Added:
bug
|
||
@HLeithner hash reduced (using the same trick as @Fedik 's PR)
I have tested this item ✅ successfully on bb5af54
retest with shorter hash lenght, still works
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42038.
@dgrammatiko I did run the build.php script with your PR applied. I get the following error:
> joomla@5.0.0 cssversioning
> node build/build.js --cssversioning
Error: TypeError: crypto.createHash is not a function
at fixVersion (/home/richard/lamp/public_html/joomla-cms-5.0-dev/build/tmp/1696444855/build/build-modules-js/css-versioning.es6.js:42:11)
at async Promise.all (index 40)
at async module.exports.cssVersioning (/home/richard/lamp/public_html/joomla-cms-5.0-dev/build/tmp/1696444855/build/build-modules-js/css-versioning.es6.js:55:3)
@richard67 interesting, could you try the following commit 56bd56e ?
@richard67 interesting, could you try the following commit 56bd56e ?
@dgrammatiko That works, the error is gone.
@dgrammatiko Maybe you last change was not necessary because it could have been my fault: When running php ./build/build.php --remote=HEAD on a local branch where no remote exists, I think git fetches the 5.0-dev branch from my fork, and so calls the old js file for the versioning. I'm not 100% sure yet, will check that. But the last commit seems not to do any harm either. The script seems to work, I get version numbers appended to URLs inside the css files where they include images or other css files.
@dgrammatiko Not my mistake. The error happens also with the code before the last commit when the branch can be fetched from remote, so the last commit was necessary to fix that error.
I have tested this item ✅ successfully on 56bd56e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42038.
@brianteeman Could you test again if it still works after the last changes? Thanks in advance.
can we get another test here please.
I have tested this item ✅ successfully on 56bd56e
Tested:
npm run cssversioning
node build/build.js --cssversioning
no errors and working
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42038.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42038.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-05 09:48:58 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thanks
I have tested this item ✅ successfully on 9d52aaf
Tested by installing 4.4 and then using the update url for this pr to update to j5
thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42038.