Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42030] - [4.4] translation description text static error pages

? bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
3 Oct 2023

replaces #42023 for J4.4-dev

Summary of Changes

update innerHTML of #descText1 element (translation)

Testing Instructions

produce an error page are open any static error page (html) directly
eg. domain.tl/includes/incompatible.html
switch language

Actual result BEFORE applying this Pull Request

description text is always english
image

Expected result AFTER applying this Pull Request

description is translated
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 3 Oct 2023
avatar heelc29 heelc29 - change - 3 Oct 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2023
Category ⇒ JavaScript Repository Front End Templates (site)
avatar richard67 richard67 - test_item - 5 Oct 2023 - Tested successfully
avatar richard67
richard67 - comment - 5 Oct 2023

I have tested this item ✅ successfully on 865a901

I've used the following methods to get the different html error pages and then changed the language a few times to different values.

build_incomplete.html

On a clean branch without having run composer install and npm ci, go to the site's URL.

incompatible.html

After having run composer install and npm ci but before installing Joomla, edit file installation/index.php file and change define('JOOMLA_MINIMUM_PHP', '7.2.5'); to e.g. define('JOOMLA_MINIMUM_PHP', '9.2.5');.

Then go to the site's URL.

fatal-error.html

After successful installation, delete all Joomla tables in the database of this site e.g. with phpMyAdmin and then go to the site's URL.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42030.
avatar Quy Quy - test_item - 9 Oct 2023 - Tested successfully
avatar Quy
Quy - comment - 9 Oct 2023

I have tested this item ✅ successfully on 865a901

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42030.

avatar Quy Quy - change - 9 Oct 2023
Status Pending ⇒ Ready to Commit
Labels Added: bug PR-4.4-dev
avatar Quy
Quy - comment - 9 Oct 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42030.

avatar Quy Quy - change - 9 Oct 2023
Labels Added: ?
avatar Quy Quy - change - 28 Oct 2023
Labels Added: ?
Removed: ?
avatar Quy Quy - change - 31 Oct 2023
Labels Added: ?
Removed: ?
avatar heelc29 heelc29 - change - 4 Nov 2023
Labels Added: ? ?
Removed: ?
avatar laoneo laoneo - change - 7 Nov 2023
Labels Added: ?
Removed: ? ?
avatar laoneo laoneo - change - 9 Nov 2023
Labels Added: ?
Removed: ?
avatar laoneo
laoneo - comment - 13 Nov 2023

Can you fix the conflicts and respond to my question? Would love to see this one in 4.4.1.

avatar heelc29 heelc29 - change - 13 Nov 2023
Labels Added: ?
Removed: ?
avatar heelc29
heelc29 - comment - 13 Nov 2023

Can you fix the conflicts and respond to my question?

Done

avatar Quy Quy - change - 14 Nov 2023
Labels Added: ?
Removed: ?
avatar laoneo laoneo - change - 15 Nov 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-11-15 07:03:04
Closed_By ⇒ laoneo
Labels Added: ?
Removed: ?
avatar laoneo laoneo - close - 15 Nov 2023
avatar laoneo laoneo - merge - 15 Nov 2023
avatar laoneo
laoneo - comment - 15 Nov 2023

Thanks!

Add a Comment

Login with GitHub to post a comment