[#42023] - [5.0] translation description text error pages
- Closed
- 2 Oct 2023
- Medium
- Build: 5.0-dev
- # 42023
Summary of Changes
update innerHTML of #descText1 element (translation)
Testing Instructions
produce an error page are open any error html page directly
eg. domain.tl/includes/incompatible.html
switch language
Actual result BEFORE applying this Pull Request
description text is always englisch
Expected result AFTER applying this Pull Request
description is translated
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
But then it should be fixed in 4.4-dev, too. You could leave this PR for 5.0-dev here in addition to make it easier to resolve the conflict later on upmerge, but we definitely fix bugs in 4.4-dev and merge them up to 5 when also relevant there.
Issues which appear in 4.4 have to be fixed in 4.4 (till the release of 5.2) and will be upmerged by the maintainers to 5.x.
Could you please rebase your PR for 4.4, thanks
@HLeithner This here is the PR, not the issue, so it should not be closed, it just needs to be rebased.
it's not possible (afaik) to rebase a joomla 5.0-dev pr to 4.4-dev branch
it's not possible (afaik) to rebase a joomla 5.0-dev pr to 4.4-dev branch
@HLeithner Why should that not be possible?
because all commits from 5.0-dev which are not in 4.4-dev will be in this commit and you would update 4.4-dev branch to joomla 5.0. I switched this pr to 4.4 branch for demonstration.
because all commits from 5.0-dev which are not in 4.4-dev will be in this commit and you would update 4.4-dev branch to joomla 5.0. I switched this pr to 4.4 branch for demonstration.
@HLeithner I see.
@HLeithner here we go #42030
@heelc29 Do we have this issue also in 4.4-dev, or only in 5.0-dev?