bug PR-5.0-dev
avatar wilsonge
wilsonge
1 Oct 2023

Summary of Changes

Removes the template special color from core. The only potential place this is used is in toolbar secondary buttons. As far as I can tell no core extensions actually use this. But there is a chance third parties do. We now revert back to using the default bootstrap secondary color in this case.

This is a b/c break if other people are using this CSS Var. However I can't see any obvious way for us to actually deprecate CSS variables.

Testing Instructions

Change the class of an existing button from btn-*** (success/error/action) etc. to btn-secondary.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar wilsonge wilsonge - open - 1 Oct 2023
avatar Cybernary
Cybernary - comment - 5 Oct 2023

Have tested this successfully.

avatar Quy Quy - change - 6 Oct 2023
Labels Added: bug PR-5.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2023
Category Administration Language & Strings Templates (admin) Repository NPM Change SQL Installation Postgresql Front End Templates (site)
avatar HLeithner
HLeithner - comment - 7 Oct 2023

@wilsonge deprecation is at least needed in the manual. is it critical to remove it in 5.0 or 5.x?

avatar HLeithner HLeithner - change - 18 Oct 2023
Title
[5.0] Remove template special color
[6.0] Remove template special color
avatar HLeithner HLeithner - edited - 18 Oct 2023
avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[6.0] Remove template special color
[5.1] Remove template special color
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar webmasterab
webmasterab - comment - 9 Jun 2024

Tested this but it seems that this has already been resolved.

For patch test
patch test before
installed after patch test
patch test_path installed
Removed again after patch
patch test patch revert

avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.1] Remove template special color
[5.2] Remove template special color
avatar HLeithner HLeithner - edited - 2 Sep 2024
avatar Hackwar
Hackwar - comment - 22 Nov 2024

@wilsonge could you update the PR to solve the conflicts?

Add a Comment

Login with GitHub to post a comment