[#41997] - [5.0] reactivate disabled system tests
- Fixed in Code Base
- 30 Sep 2023
- Medium
- Build: 5.0-dev
- # 41997
- Diff
- heelc29:5.0/revert-41938
User tests: Successful: Unsuccessful:
Reverts part of #41938 @HLeithner
Summary of Changes
tests/System/integration/administrator/components/com_privacy/Consent.cy.js
can invalidate (all) privacy consents: use new joomla dialog
can displays correct number of consents: LimitboxField broken in #41655 (All is no longer available by default) @Denitz
tests/System/integration/api/com_users/Users.cy.js
can delete a user: should already work
plugins/system/accessibility/src/Extension/Accessibility.php
use emojis as default (like in J4) to match the XML default value
Testing Instructions
drone
Actual result BEFORE applying this Pull Request
tests fails in J5
Expected result AFTER applying this Pull Request
all test working in J5
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries JavaScript Unit Tests |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
Worth noting if this logic is broken the character counter was changed the same way for the textarea and text fields and will also need fixing.
@wilsonge I don't think so, because the default value there is false.
<?php
$element1 = ['charcounter'=>'true'];
$element2 = ['charcounter'=>'false'];
$charcounter1 = isset($element1['charcounter']) ? strtolower($element1['charcounter']) === 'true' : false;
$charcounter2 = isset($element1['charcounter']) && strtolower($element1['charcounter']) === 'true';
//---
$charcounter3 = isset($element2['charcounter']) ? strtolower($element2['charcounter']) === 'true' : false;
$charcounter4 = isset($element2['charcounter']) && strtolower($element2['charcounter']) === 'true';
//---
$charcounter5 = isset($element3['charcounter']) ? strtolower($element3['charcounter']) === 'true' : false;
$charcounter6 = isset($element3['charcounter']) && strtolower($element3['charcounter']) === 'true';
var_dump($charcounter1);
var_dump($charcounter2);
//---
var_dump($charcounter3);
var_dump($charcounter4);
//---
var_dump($charcounter5);
var_dump($charcounter6);
RESULT
========
bool(true)
bool(true)
bool(false)
bool(false)
bool(false)
bool(false)
But I think here: System - Additional Accessibility Features
https://github.com/joomla/joomla-cms/pull/41655/files#diff-9bedf3dbc892473655aff83c8641697cb9e33dda115cdec1c72f277c36e3a407
J4
J5
@heelc29 Please check heelc29/joomla-cms@5.0/revert-41938...Denitz:joomla-cms:patch-14 to have useEmojis enabled by default to follow XML default value.
| Category | Libraries JavaScript Unit Tests | ⇒ | Libraries Front End Plugins JavaScript Unit Tests |
| Labels |
Added:
?
PR-5.0-dev
|
||
@heelc29 Please check heelc29/joomla-cms@5.0/revert-41938...Denitz:joomla-cms:patch-14 to have useEmojis enabled by default to follow XML default value.
@Denitz Thanks. I tested it and added it to this PR.
@wilsonge I think @heelc29 is right. Can be easily seen here how PR #41655 has changed the code: https://github.com/joomla/joomla-cms/pull/41655/files#diff-ca25794ee2bfa85c060ef0699fa868d30b27e6d8022a92eb657ac165e7fa6a29L85 . If not set we got true in before and false after that change:
I have tested this item ✅ successfully on bea152c
By review of the changes here and those from #41655 : The PR here restores the logic from before #41655 for the options which defaulted to true when not being set.
System tests in Drone which are reactivated by this PR here are passing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41997.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-30 20:04:49 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
Release Blocker
|
||
thanks
Worth noting if this logic is broken the character counter was changed the same way for the textarea and text fields and will also need fixing.