? PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
26 Sep 2023

Summary of Changes

re-enable one of the disabled test from #41938

avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2023
Category JavaScript Unit Tests
avatar alikon alikon - open - 26 Sep 2023
avatar alikon alikon - change - 26 Sep 2023
Status New Pending
avatar alikon alikon - change - 26 Sep 2023
Labels Added: ? PR-5.0-dev
avatar alikon alikon - change - 26 Sep 2023
The description was changed
avatar alikon alikon - edited - 26 Sep 2023
avatar alikon alikon - change - 26 Sep 2023
Title
[wip] check 1st current id
[5]re-enable one of the disabled test
avatar alikon alikon - edited - 26 Sep 2023
avatar wilsonge
wilsonge - comment - 26 Sep 2023

What does this number represent? Is it the number of installed extensions (hope not because it sounds high - but can’t think what else)? A code comment is going to be gold here!

avatar alikon
alikon - comment - 27 Sep 2023

it's the extension_id of the "files_joomla"

avatar HLeithner
HLeithner - comment - 27 Sep 2023

is this test really useful as it is? I mean it seems that "files_joomla" is a moving target is there any more static thing?

avatar HLeithner
HLeithner - comment - 27 Sep 2023
avatar laoneo
laoneo - comment - 27 Sep 2023

is this test really useful as it is? I mean it seems that "files_joomla" is a moving target is there any more static thing?

This guy here removed the hardcoded id 700 for files_joomla.

@alikon, we should probably fetch that id first by database, before we tests and then test for the returned id.

avatar alikon
alikon - comment - 27 Sep 2023

@HLeithner

is there any more static thing?

yes switched to the offline property

avatar HLeithner
HLeithner - comment - 27 Sep 2023

@HLeithner

is there any more static thing?

yes switched to the offline property

thanks, can be merged when test is successful.

avatar HLeithner HLeithner - close - 27 Sep 2023
avatar HLeithner HLeithner - merge - 27 Sep 2023
avatar HLeithner HLeithner - change - 27 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-27 10:17:19
Closed_By HLeithner

Add a Comment

Login with GitHub to post a comment