Composer Dependency Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
26 Sep 2023

Pull Request for Issue # .

Summary of Changes

In the 4.4-dev branch we currently have in composer.json "maximebf/debugbar": "dev-master". This resolves in commit "30f65f18f7ac086255a77a079f8e0dcdd35e828e" in the lock file. This commit belongs to their version "1.19.0".

In the 5.0-dev branch we have in composer.json "maximebf/debugbar": "^1.18.2", which results in version "1.18.2" being used, which is the version before the "1.19.0", see maximebf/php-debugbar@v1.18.2...v1.19.0 .

That means that when we currently update the CMS from 4.4 to 5, we downgrade the "maximebf/debugbar" dependency.

This PR here fixes that by updating the maximebf/debugbar dependency to version "1.19.0" here in the 5.0-dev branch, together with a PR for 4.4-dev to change there from "dev-master" to "^1.19.0", too.

The PR here might become obsolete when the other one has been merged into 4.40-dev and that has been upmerged to 5.0-dev then. But it can be used to check the result of that.

Testing Instructions

Check that the debug bar works.

Actual result BEFORE applying this Pull Request

Works.

Expected result AFTER applying this Pull Request

Still works.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2023
Category External Library Composer Change
avatar richard67 richard67 - open - 26 Sep 2023
avatar richard67 richard67 - change - 26 Sep 2023
Status New Pending
avatar richard67 richard67 - change - 26 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 26 Sep 2023
avatar HLeithner HLeithner - change - 26 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-26 09:57:41
Closed_By HLeithner
Labels Added: Composer Dependency Changed PR-5.0-dev
avatar HLeithner HLeithner - close - 26 Sep 2023
avatar HLeithner HLeithner - merge - 26 Sep 2023
avatar HLeithner
HLeithner - comment - 26 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment