Composer Dependency Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
26 Sep 2023

Pull Request for Issue # .

Summary of Changes

In the 4.4-dev branch we currently have in composer.json "maximebf/debugbar": "dev-master". This resolves in commit "30f65f18f7ac086255a77a079f8e0dcdd35e828e" in the lock file. This commit belongs to their version "1.19.0".

In the 5.0-dev branch we have in composer.json "maximebf/debugbar": "^1.18.2", which results in version "1.18.2" being used, which is the version before the "1.19.0", see maximebf/php-debugbar@v1.18.2...v1.19.0 .
That means that when we currently update the CMS from 4.4 to 5, we downgrade the "maximebf/debugbar" dependency.
Update: This has been solved with PR #41932 .

This PR here fixes that by changing the "dev-master" to "^1.19.0" here in the 4.4-dev branch so we still use the same version but won't get an update when we don't want that, together with PR #41932 for 5.0-dev to change there from "^1.18.2" to "^1.19.0", too.

Testing Instructions

Check that the debug bar works.

Actual result BEFORE applying this Pull Request

Works.

Expected result AFTER applying this Pull Request

Still works.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2023
Category External Library Composer Change
avatar richard67 richard67 - open - 26 Sep 2023
avatar richard67 richard67 - change - 26 Sep 2023
Status New Pending
avatar richard67 richard67 - change - 26 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 26 Sep 2023
avatar richard67 richard67 - change - 26 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 26 Sep 2023
avatar laoneo laoneo - close - 26 Sep 2023
avatar laoneo laoneo - merge - 26 Sep 2023
avatar laoneo laoneo - change - 26 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-26 11:11:33
Closed_By laoneo
Labels Added: Composer Dependency Changed PR-4.4-dev
avatar laoneo
laoneo - comment - 26 Sep 2023

Thanks!

Add a Comment

Login with GitHub to post a comment