Feature Language Change NPM Resource Changed PBF PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar beni71
beni71
26 Sep 2023

Pull Request for Issue #23304, only partially.
This PR is based on #38583 and fixes the comments.

Summary of Changes

Adds the ability to batch copy/move tags in the tags list.
Copying a tag also copies its children (same behavior as in other tree models like categories, menues).
Moving a tag also moves its children (same behavior as in other tree models like categories, menues).
For example, it is possible to move a child tag from one parent to another (including its children), or to copy a child tag from one parent to another (including its children).
In the batch tag drop down there is also an item "Root" to move/copy selected tags to the root level.

Changed visualization "Action to Perform" of copy/move action, it is now hidden as long as the user does not touch the select field for copy/move. See example in video below. This change affects batch copy/move dialog of menues and articles as well.

It also fixes a browser console error when the batch dialog is opened and cancel is clicked, on systems where multilingual is disabled.

Testing Instructions

It contains an updated javascript so run: npm run build:js

Initial tag structure for each of the tests below:
Tag1
-Tag2
--Tag3
Tag4

Test 1
Move Tag2 to Tag4 results in:
Tag1
Tag4
-Tag2
--Tag3

Test 2
Move Tag1 to Tag4 results in:
Tag4
-Tag1
--Tag2
---Tag3

Test 3
Copy Tag4 to Tag2 result in:
Tag1
-Tag2
--Tag3
--Tag4 (2)
Tag4

Test 4
Check whether the visualization of "Action to Perform" of copy/move action is first hidden for views like menues, articles. Only if a target item is selected "Action to Perform" appears.

Actual result BEFORE applying this Pull Request

The tags list batch processing does not support copy move.

Expected result AFTER applying this Pull Request

The tags list batch processing supports copy move:

tag-copy-move

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2023
Category Administration com_categories com_menus com_tags Language & Strings JavaScript Repository NPM Change
avatar beni71 beni71 - open - 26 Sep 2023
avatar beni71 beni71 - change - 26 Sep 2023
Status New Pending
avatar beni71 beni71 - change - 26 Sep 2023
The description was changed
avatar beni71 beni71 - edited - 26 Sep 2023
avatar beni71 beni71 - change - 26 Sep 2023
The description was changed
avatar beni71 beni71 - edited - 26 Sep 2023
avatar beni71 beni71 - change - 26 Sep 2023
The description was changed
avatar beni71 beni71 - edited - 26 Sep 2023
avatar beni71 beni71 - change - 26 Sep 2023
Labels Added: Feature Language Change NPM Resource Changed PR-5.0-dev
avatar ceford ceford - test_item - 26 Sep 2023 - Tested successfully
avatar ceford
ceford - comment - 26 Sep 2023

I have tested this item ✅ successfully on c503b03

Easy to get into a muddle but works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.

avatar HLeithner HLeithner - change - 26 Sep 2023
Title
[5.0] Batch Copy & Move tags
[5.1] Batch Copy & Move tags
avatar HLeithner HLeithner - edited - 26 Sep 2023
avatar chmst
chmst - comment - 26 Sep 2023

Thanks a lot for working on this issue! Unfortunately I am not in favour of this implementation, from UX point of view.
Batch copy and move is not quite easy to understand, but at least the process should be everywhere the same. Behavoiur must be predictable.
Would it be possible to implement this behaviour "as always"?

Always:

user selects an item in the list and activates the batch button
(the system has the ids of the selected items)

on the modal: the users selects a target for his copy or move from the dropdown

decides if the action copy or move is to be performed.

your implementation

user selects an item in the list and activates the batch button (as he uses to do in other places)
(the system ignores the selection)

grafik
The "keep original tag" is misleading. The user's selection in the list is ignored, he must select the items now in the dropdown list.

After the selection of an item from the list, the select is replaced by another question. This change is so fast and the texts look similiar that it is difficult to notice the replacement. The user could think that he still sees his selection.

grafik

It would be clearer if the new block is appended to the first one.

The process then works like a charm.

I think that this causes confusion

In my opinion, the process should be the same in all categories and all other components, then it does not need extra documentation.

avatar brianteeman
brianteeman - comment - 26 Sep 2023

@chmst isnt this identical to the ui for batch copying and moving menu items??

avatar chmst
chmst - comment - 26 Sep 2023

@brianteeman not if I understand this correctly

You choose a menuitem in the list (the systems holds the id), opens the batch modal

grafik

then you choose a target menuitem and decides if you want a copy or move.

You must not do this first step and select your item in the batch modal.

avatar brianteeman
brianteeman - comment - 26 Sep 2023

image

image

image

image

I dont see the difference

I think the confusion is because the language string is wrong
it should not be Keep Original Tags
it should be Dont Copy or move

image

avatar chmst
chmst - comment - 27 Sep 2023

Yes, thanks for explainingt. The language string is the first reason for confusion. But it must be "select a tag". Just open the dropdown.

The second is: Why not accept the selection of items to move or copy from the overview? In com_menus and in categories we don't have an extra step for that. Maybe there is something special in tags which requires that?

avatar brianteeman
brianteeman - comment - 27 Sep 2023

@chmst Sorry I dont understand what you are talking about

avatar chmst
chmst - comment - 27 Sep 2023

I am sorry that I cannot explain. Will try it later with videos.

avatar chmst
chmst - comment - 27 Sep 2023

@brianteeman you were correct. - it seems that this language string caused the whole confusion and my folloing action was overreaction.
So it will be an easy fix. Thanks for your patience.

avatar beni71 beni71 - change - 27 Sep 2023
The description was changed
avatar beni71 beni71 - edited - 27 Sep 2023
avatar beni71
beni71 - comment - 27 Sep 2023

Sorry for that confusion. I fixed the text and updated the description part of the PR.

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar Quy
Quy - comment - 7 Oct 2023
avatar beni71 beni71 - change - 7 Oct 2023
Labels Added: PR-5.1-dev
Removed: PR-5.0-dev
avatar steffans steffans - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar steffans
steffans - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 78aad67

My result for Test 2 looks like this, which is what i would expect. But its not mentioned in the test instructions.

Test 2
Tag4
-Tag2
--Tag3
-Tag1

Fails to copy the tags recursively, somehow the Tag 4 is added 2x, see Tag4 (15) and --Tag4 (8)?

Test 3
Tag4
-Tag2
--Tag3
--Tag4 (8)
---Tag2 (8)
----Tag3 (5)
----Tag4 (15)
---Tag1 (2)
-Tag1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.
avatar exlemor exlemor - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar exlemor
exlemor - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 78aad67

When I try to do the first move of -Tag2 --Tag3 under Tab4, I do not even have a Move or Copy dialog/set of buttons underneath the "To Move or Copy your selection please select a Tag or parent item" dropdown.

:(


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.

avatar steffans
steffans - comment - 24 Feb 2024

@exlemor You need to compile the Javascript using "npm ci" in order to test this PR

avatar crimle crimle - test_item - 24 Feb 2024 - Tested successfully
avatar crimle
crimle - comment - 24 Feb 2024

I have tested this item ✅ successfully on 78aad67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.

avatar Razzo1987 Razzo1987 - change - 24 Feb 2024
Labels Added: PBF
avatar adj9
adj9 - comment - 24 Feb 2024

The process works, but in the batch a way to override the parent tag would be useful. Take it to the root level


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.

avatar Hackwar
Hackwar - comment - 26 Feb 2024

@beni71 Thank you for your work, however it looks as if we need some more adjustments. It seems as if the hierarchy is not maintained? Could you have a look?

avatar beni71
beni71 - comment - 26 Feb 2024

Hi all. Thanks for testing this feature. There are a couple of things I have to go one by one.

@steffans I'm not sure whether you didn't exactly follow the test instructions or you really found an issue. So let's go into details of test2 first:
The initial tag structure is:
Tag1
-Tag2
--Tag3
Tag4

Which means that Tag1 an Tag4 are both on root level, Tag2 is a sub-tag of Tag1 and Tag3 is a sub-tag of Tag2.
So when I move Tag1 to Tag4 then Tag1 should be a sub-tag of Tag4, like:
Tag4
-Tag1
--Tag2
---Tag3

Can you tell me how your repro steps were to get:
Tag4
-Tag2
--Tag3
-Tag1

avatar beni71
beni71 - comment - 26 Feb 2024

@adj9 Regarding

The process works, but in the batch a way to override the parent tag would be useful. Take it to the root level

Do you mean something like: -Root-

Screenshot 2024-02-26 201648

Or what about: - No parent -

avatar beni71 beni71 - change - 3 Mar 2024
The description was changed
avatar beni71 beni71 - edited - 3 Mar 2024
avatar beni71
beni71 - comment - 3 Mar 2024

Extended the batch tag drop down with a "Root" item to move/copy selected tags to the root level, suggested by @adj9.
I updated the description.

avatar beni71 beni71 - change - 6 Apr 2024
Labels Added: b/c break
avatar beni71
beni71 - comment - 6 Apr 2024

@bembelimen Can you please tell me where the breaking change is? Do I need to fix it?

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[5.1] Batch Copy & Move tags
[5.2] Batch Copy & Move tags
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar beni71 beni71 - change - 18 Jul 2024
Labels Added: PR-5.2-dev
avatar beni71 beni71 - change - 21 Jul 2024
Labels Removed: PR-5.1-dev
avatar cybersalt cybersalt - test_item - 20 Aug 2024 - Tested unsuccessfully
avatar cybersalt
cybersalt - comment - 20 Aug 2024

I have tested this item ? unsuccessfully on 715e848

The copy and move radio buttons did not show up for me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.

avatar alikon
alikon - comment - 20 Aug 2024

did you run: npm run build:js first ?

avatar fgsw
fgsw - comment - 21 Aug 2024

Download Prebuilt packages result in a 404.

@Quy Thanks solving Problem.

avatar fgsw fgsw - test_item - 21 Aug 2024 - Tested successfully
avatar fgsw
fgsw - comment - 21 Aug 2024

I have tested this item ✅ successfully on 715e848


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.

avatar bascherz bascherz - test_item - 24 Aug 2024 - Tested unsuccessfully
avatar bascherz
bascherz - comment - 24 Aug 2024

I have tested this item ? unsuccessfully on 715e848

The Copy/Move radio buttons do not appear. The action performed is Move.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.

avatar cybersalt
cybersalt - comment - 24 Aug 2024

I have tested this item ? unsuccessfully on 715e848The copy and move radio buttons did not show up for me.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.

I just learned what an NPM patch is and that it can't be tested through the patchtester as I was using it on a copy of my live site on the server. So please disregard my failed test!

avatar obuisard
obuisard - comment - 24 Aug 2024

I have tested this item ? unsuccessfully on 715e848The Copy/Move radio buttons do not appear. The action performed is Move.

Bruce @bascherz, did you use the patch tester extension for your tests? Pull requests that are tagged 'NPM Resource Changed' need to be tested locally, they cannot be tested straight from our PBF instances, unfortunately. That's because a script file has been modified and the Joomla instance needs to be rebuilt to be able to get tested.

avatar fgsw
fgsw - comment - 28 Aug 2024

I just learned what an NPM patch is and that it can't be tested through the patchtester

@cybersalt you can use instead a prebuilt package. Download at the end of this pull request.

So please disregard my failed test!

if you don't test again you can set back the test result at the issue tracker by "Test this > Not tested".

avatar cybersalt cybersalt - test_item - 30 Aug 2024 - Not tested
avatar cybersalt
cybersalt - comment - 30 Aug 2024

I have not tested this item.

My Pizza Bugs and Fun test was first marked as a fail, but then I learned that I could not test this one with the patch tester - so I am resetting this to "not tested" so as to not confuse things.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.

avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.2] Batch Copy & Move tags
[5.3] Batch Copy & Move tags
avatar HLeithner HLeithner - edited - 2 Sep 2024
avatar beni71 beni71 - change - 4 Oct 2024
Labels Added: PR-5.3-dev
Removed: PR-5.2-dev
avatar Quy Quy - change - 30 Oct 2024
Labels Removed: b/c break

Add a Comment

Login with GitHub to post a comment