NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
25 Sep 2023

Pull Request for Issue #41793 .

Summary of Changes

Fix the hover color of toolbar icons when in dark mode to something less painful on the eye

Testing Instructions

Hover over any info buttons. Examples are the help page icon or the toggle inline help icon.

Actual result BEFORE applying this Pull Request

toggle-inline-help

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2023
Category Repository NPM Change
avatar wilsonge wilsonge - open - 25 Sep 2023
avatar wilsonge wilsonge - change - 25 Sep 2023
Status New Pending
avatar Quy Quy - test_item - 25 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 25 Sep 2023

I have tested this item ✅ successfully on bf7108d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41923.

avatar wilsonge wilsonge - change - 25 Sep 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar Quy
Quy - comment - 25 Sep 2023

On hover, it is a tad dark.

avatar wilsonge
wilsonge - comment - 25 Sep 2023

The color of the text? Because background should be the same

avatar Quy
Quy - comment - 25 Sep 2023

Yes, the text color is close to the background color.

dark-dropdown-hover

avatar HLeithner HLeithner - change - 26 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-26 14:24:30
Closed_By HLeithner
avatar HLeithner HLeithner - close - 26 Sep 2023
avatar HLeithner HLeithner - merge - 26 Sep 2023

Add a Comment

Login with GitHub to post a comment