Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41922] - [5.0] Use existing SCSS variable for box shadow so we're more consistent

NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
25 Sep 2023

Summary of Changes

Uses a predefined SCSS variable to make our lives easier when trying to identify identical elements.

Testing Instructions

Code review. SCSS still compiles in drone. Validate the SCSS variable here https://github.com/joomla/joomla-cms/blob/4.3-dev/build/media_source/templates/administrator/atum/scss/_variables.scss#L104 is the same as the code being replaced

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2023
Category ⇒ Repository NPM Change
avatar wilsonge wilsonge - open - 25 Sep 2023
avatar wilsonge wilsonge - change - 25 Sep 2023
Status New ⇒ Pending
avatar wilsonge wilsonge - change - 25 Sep 2023
Title
…
Use SCSS vars so we're more consistent
[5.0] Use existing SCSS variable for box shadow so we're more consistent
avatar wilsonge wilsonge - edited - 25 Sep 2023
avatar Quy Quy - test_item - 25 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 25 Sep 2023

I have tested this item ✅ successfully on 4af8818

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41922.

avatar HLeithner HLeithner - change - 26 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-26 05:17:15
Closed_By ⇒ HLeithner
Labels Added: NPM Resource Changed PR-5.0-dev
avatar HLeithner HLeithner - close - 26 Sep 2023
avatar HLeithner HLeithner - merge - 26 Sep 2023
avatar HLeithner
HLeithner - comment - 26 Sep 2023

Thx

Add a Comment

Login with GitHub to post a comment