[#41920] - [5.0] Fix styling of create module view in dark mode
- Fixed in Code Base
- 26 Sep 2023
- Medium
- Build: 5.0-dev
- # 41920
- Diff
- wilsonge:fix/dark-mode-module-create
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #41802.
Summary of Changes
Fixes the styling of the create module view in dark mode. Removes the card body class which as far as I can tell is redundant because we aren't using the parent card class but it does override the color of the text.
This is now explicitly sharing the same colors as the quickicons in cpanel (although the hover effects are slightly different as the plus icon isn't a separate action from the main body of text)
Testing Instructions
Create a module in light mode. There shouldn't be a significant change (there will be very minor color changes). Create it in dark mode and it looks like the below image
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_modules Repository NPM Change |
| Status | New | ⇒ | Pending |
HLeithner
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-26 14:07:57 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
Reached out to you on mattermost
I have tested this item ✅ successfully on 210188d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41920.