? NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
25 Sep 2023

Pull Request for Issue #41818 .

Summary of Changes

Changes the icon color to reflect text color and removes the near invisible backgroundl

Testing Instructions

Check icon dashboard per original issue in both light and dark mode. The light mode will change color a fraction but shouldn't be significantly noticeable.

Actual result BEFORE applying this Pull Request

menu-dashboard-home

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2023
Category Repository NPM Change
avatar wilsonge wilsonge - open - 25 Sep 2023
avatar wilsonge wilsonge - change - 25 Sep 2023
Status New Pending
avatar Quy Quy - test_item - 25 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 25 Sep 2023

I have tested this item ✅ successfully on 7f01e34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41919.

avatar richard67 richard67 - test_item - 25 Sep 2023 - Tested successfully
avatar richard67
richard67 - comment - 25 Sep 2023

I have tested this item ✅ successfully on 7f01e34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41919.

avatar richard67 richard67 - change - 25 Sep 2023
Status Pending Ready to Commit
Labels Added: NPM Resource Changed PR-5.0-dev
avatar richard67
richard67 - comment - 25 Sep 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41919.

avatar Quy Quy - change - 26 Sep 2023
Labels Added: ?
avatar HLeithner HLeithner - close - 26 Sep 2023
avatar HLeithner HLeithner - merge - 26 Sep 2023
avatar HLeithner HLeithner - change - 26 Sep 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-26 05:16:23
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 26 Sep 2023

Thx

Add a Comment

Login with GitHub to post a comment