User tests: Successful: Unsuccessful:
Pull Request for Issue #41911 .
Use the $document
variable which is assigned a few lines above the change of this PR where we already have the result of a $this->getApplication()->getDocument()
call, so it doesn't need the $app = Factory::getApplication();
which causes the exception due to a missing use
statement, and it doesn't need the $app->getDocument()
.
Same fix as done with PR #41073 in the 5.0-dev branch for issue #41072 .
Use a current 4.4-dev branch or a 4.4.0-beta2.
See issue #41911 .
The user gets logged in after entering their PIN.
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
Category | ⇒ | Front End Plugins |
Status | New | ⇒ | Pending |
Drone complains about a code style error (unnecessary use statement) at a place which I haven't changed with this PR. Will fix it anyway.
Update: I see, it became obsolete due to my removal of the code including the /** @var CMSApplication $app */
comment.
Labels |
Added:
Release Blocker
bug
PR-4.4-dev
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-25 11:51:34 |
Closed_By | ⇒ | wilsonge |
I have tested this item ✅ successfully on 1766e12
@richard67 .... und noch viele Grüße aus dem Main-Kinzig-Kreis an die Bergstraße!!!
I have tested this item ✅ successfully on 2219b73
Code review, it is a fix of an obvious mistake
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41917.