Release Blocker bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
25 Sep 2023

Pull Request for Issue #41906 .

Summary of Changes

Fix event compatibility for UserGroupDelete events

Testing Instructions

Try delete User group

Actual result BEFORE applying this Pull Request

An error

Expected result AFTER applying this Pull Request

Group is deleted without error

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: joomla/Manual#197
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2023
Category Administration com_users Libraries
avatar Fedik Fedik - open - 25 Sep 2023
avatar Fedik Fedik - change - 25 Sep 2023
Status New Pending
avatar Fedik Fedik - change - 25 Sep 2023
Labels Added: Release Blocker bug PR-5.0-dev
avatar HLeithner
HLeithner - comment - 25 Sep 2023

Please introduce new extended classes for before and after, we don't know how long we really have this event and as you did it now you just pollute the constructor used for all other events

avatar Fedik
Fedik - comment - 25 Sep 2023

Changed

avatar richard67 richard67 - test_item - 25 Sep 2023 - Tested successfully
avatar richard67
richard67 - comment - 25 Sep 2023

I have tested this item ✅ successfully on 1cf9784


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41916.

avatar HLeithner HLeithner - close - 25 Sep 2023
avatar HLeithner HLeithner - merge - 25 Sep 2023
avatar HLeithner HLeithner - change - 25 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-25 17:21:15
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 25 Sep 2023

thanks

avatar Fedik Fedik - change - 27 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 27 Sep 2023

Add a Comment

Login with GitHub to post a comment